Skip to content

Added backupDR flag#16269

Merged
slevenick merged 4 commits intoGoogleCloudPlatform:mainfrom
agamkrbit:filestore-backupdr
Feb 25, 2026
Merged

Added backupDR flag#16269
slevenick merged 4 commits intoGoogleCloudPlatform:mainfrom
agamkrbit:filestore-backupdr

Conversation

@agamkrbit
Copy link
Copy Markdown
Contributor

@agamkrbit agamkrbit commented Feb 2, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

filestore: added `source_backupdr_backup` field to `google_filestore_instance` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 2, 2026
@agamkrbit
Copy link
Copy Markdown
Contributor Author

/gcbrun

@agamkrbit agamkrbit marked this pull request as ready for review February 2, 2026 09:15
@github-actions github-actions Bot requested a review from slevenick February 2, 2026 09:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Comment thread mmv1/products/filestore/Instance.yaml Outdated
@modular-magician modular-magician added service/filestore and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 2, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 128 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 128 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 5 files changed, 47 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 22
Passed tests: 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • filestore

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFilestoreInstance_restoreBackupDR
  • TestAccFilestoreInstance_restoreBackupDR_conflicts

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_restoreBackupDR [Error message] [Debug log]
TestAccFilestoreInstance_restoreBackupDR_conflicts [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 10, 2026
@github-actions github-actions Bot requested a review from slevenick February 10, 2026 06:02
@github-actions
Copy link
Copy Markdown

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 17, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 180 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 180 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 39 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFilestoreInstance_restoreBackupDR

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccFilestoreInstance_restoreBackupDR [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on a workaround to deleting the backups

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 23, 2026
@github-actions github-actions Bot requested a review from slevenick February 23, 2026 10:32
@agamkrbit
Copy link
Copy Markdown
Contributor Author

/gcbrun

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 25, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 175 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 4 files changed, 175 insertions(+), 4 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 39 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 21
Passed tests: 20
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • filestore

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFilestoreInstance_restoreBackupDR

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccFilestoreInstance_restoreBackupDR [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@slevenick slevenick added this pull request to the merge queue Feb 25, 2026
Merged via the queue into GoogleCloudPlatform:main with commit a3d7f53 Feb 25, 2026
25 checks passed
riteshghorse pushed a commit to riteshghorse/magic-modules that referenced this pull request Feb 26, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
habh-11 pushed a commit to habh-11/magic-modules that referenced this pull request Mar 2, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants