chore: Migrate gsutil usage to gcloud storage#1377
chore: Migrate gsutil usage to gcloud storage#1377bhandarivijay-png wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
Conversation
|
Hi @cjac, Can we get your review on this PR? Thanks! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically migrates various shell scripts and Python test files from using the legacy Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the migration from gsutil to gcloud storage across several shell scripts and a Python test file. A critical security concern was identified in beam/util/build-beam-artifacts.sh where unquoted variables could lead to command or argument injection. Furthermore, there are opportunities to improve code style and readability in datasketches/datasketches.sh and hbase/test_hbase.py.
| function build_job_service() { | ||
| ./gradlew :beam-runners-flink_2.11-job-server:shadowJar | ||
| gsutil cp \ | ||
| gcloud storage cp \ |
There was a problem hiding this comment.
The gcloud storage cp command uses unquoted variables ${BEAM_JOB_SERVICE_DESTINATION} and ${BEAM_SOURCE_VERSION} on line 18. This can lead to command injection or argument injection if these variables contain shell metacharacters or start with a hyphen. While the change is on line 16, it is part of the same command. It is recommended to quote these variables and use -- to signal the end of options.
| gcloud storage cp \ | |
| gcloud storage cp -- \ | |
| ./runners/flink/job-server/build/libs/beam-runners-flink_2.11-job-server-*-SNAPSHOT.jar \ | |
| "${BEAM_JOB_SERVICE_DESTINATION}/beam-runners-flink_2.11-job-server-${BEAM_SOURCE_VERSION}-SNAPSHOT.jar" |
| self.assert_command('gcloud storage buckets create --default-storage-class=regional --location {} gs://{}'.format( | ||
| self.REGION, self.GCS_BUCKET)) |
There was a problem hiding this comment.
This command string is getting long. To improve readability, you could break it into multiple lines and assign it to a variable before passing it to self.assert_command.
| self.assert_command('gcloud storage buckets create --default-storage-class=regional --location {} gs://{}'.format( | |
| self.REGION, self.GCS_BUCKET)) | |
| create_bucket_cmd = ( | |
| 'gcloud storage buckets create ' | |
| '--default-storage-class=regional ' | |
| '--location {} gs://{}' | |
| ).format(self.REGION, self.GCS_BUCKET) | |
| self.assert_command(create_bucket_cmd) |
|
|
||
| def tearDown(self): | ||
| self.assert_command('gsutil -m rm -rf gs://{}'.format(self.GCS_BUCKET)) | ||
| self.assert_command('gcloud storage rm --recursive --continue-on-error gs://{}'.format(self.GCS_BUCKET)) |
There was a problem hiding this comment.
This command string is a bit long. For better readability, consider assigning it to a variable on a separate line and breaking it up for clarity.
rm_bucket_cmd = (
'gcloud storage rm --recursive --continue-on-error gs://{}'
).format(self.GCS_BUCKET)
self.assert_command(rm_bucket_cmd)
|
Sure, I'll take a look today |
2 participants
Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy
gsutiltool to the new and improvedgcloud storagecommand-line interface.gcloud storageis the recommended and modern tool for interacting with Google Cloud Storage, offering better performance, unified authentication, and a more consistent command structure with othergcloudcomponents. 🚀Automation Details
This change was generated automatically by an agent that targets users of
gsutil.The transformations applied are based on the gsutil to gcloud storage migration guide.
While we have based the automation on the migration guide, every use case is unique.
It is crucial that you thoroughly test these changes in environments appropriate to your use-case before merging.
Be aware of potential differences between
gsutilandgcloud storagethat could impact your workflows.For instance, the structure of command output may have changed, requiring updates to any scripts that parse it. Similarly, command behavior can differ subtly; the
gcloud storage rsynccommand has a different file deletion logic thangsutil rsync, which could lead to unintended file deletions.Our migration guides can help guide you through a list of mappings and some notable differences between the two tools.
Standard presubmit tests are run as part of this CL's workflow. If you need to target an additional test workflow or require assistance with testing, please let us know.
Please verify that all your Cloud Storage operations continue to work as expected to avoid any potential disruptions in production.
Support and Collaboration
The
GCS CLIteam is here to help! If you encounter any issues, have a complex use case that this automated change doesn't cover, or face any other blockers, please don't hesitate to reach out.We are happy to work with you to test and adjust these changes as needed.
Contact:
gcs-cli-hyd@google.comWe appreciate your partnership in this important migration effort!
#gsutil-migration