Skip to content

fix: update minimum GitVersion.Tool to 6.2.0 so output is compatible#2086

Open
MarcelGosselin wants to merge 1 commit into
GitTools:mainfrom
MarcelGosselin:fix/issue-1824
Open

fix: update minimum GitVersion.Tool to 6.2.0 so output is compatible#2086
MarcelGosselin wants to merge 1 commit into
GitTools:mainfrom
MarcelGosselin:fix/issue-1824

Conversation

@MarcelGosselin
Copy link
Copy Markdown

Fixes #1824

Starting at version 4.2.0 of gittools/actions/gitversion, thanks to !1815, we no longer read the output of GitVersion.Tool from stdout but rather from a file on disk.

However, before version 6.2.0 of GitVersion.Tool, the output file was encoded as UTF-8 with a BOM. When parsing the content of the file, JSON.parse(content); fails with:

SyntaxError: Unexpected token '', "{
  "Ass"... is not valid JSON
    at JSON.parse (<anonymous>)

This PR modifies the minimum requirements for the GitVersion.Tool to the version which saves the output as UTF-8 (without BOM) which is 6.2.0. In that version, the !4443 changed all file access and as a side-effect changed the encoding of the output file.

I am not sure how I was supposed to handle the version numbers in docs/versions.md, I am open to comments

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ISSUE]: GitHub Action fails parsing GitVersion variables file in v4.2

1 participant