fix: update minimum GitVersion.Tool to 6.2.0 so output is compatible#2086
Open
MarcelGosselin wants to merge 1 commit into
Open
fix: update minimum GitVersion.Tool to 6.2.0 so output is compatible#2086MarcelGosselin wants to merge 1 commit into
MarcelGosselin wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1824
Starting at version 4.2.0 of gittools/actions/gitversion, thanks to !1815, we no longer read the output of GitVersion.Tool from stdout but rather from a file on disk.
However, before version 6.2.0 of GitVersion.Tool, the output file was encoded as UTF-8 with a BOM. When parsing the content of the file,
JSON.parse(content);fails with:This PR modifies the minimum requirements for the GitVersion.Tool to the version which saves the output as UTF-8 (without BOM) which is 6.2.0. In that version, the !4443 changed all file access and as a side-effect changed the encoding of the output file.
I am not sure how I was supposed to handle the version numbers in docs/versions.md, I am open to comments