log all exceptions + log stacktrace#237
Merged
Merged
Conversation
p-
requested review from
JarLob,
Kwstubbs,
anticomputer,
kevinbackhouse,
m-y-mo and
sylwia-budzynska
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates async task execution error logging in runner.py to include stack traces when exceptions are returned from asyncio.gather(..., return_exceptions=True).
Changes:
- Broadened the post-
gatherresult check from “is an Exception” to “is not a bool”. - Added
exc_info=...to the error log to include exception traceback details.
Show a summary per file
| File | Description |
|---|---|
src/seclab_taskflow_agent/runner.py |
Adjusts how asyncio.gather results are classified/logged, aiming to log returned exceptions with stack traces. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+659
to
661
| if not isinstance(result, bool): | ||
| logging.error(f"Caught exception in Gather: {result}", exc_info=result) | ||
| result = False |
m-y-mo
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.