[CHA-2595] ci: enforce manually triggered release flow#30
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions release workflow to only run via manual dispatch, simplifying the release gating/version-bump logic in CI and aligning release execution with an explicit operator-triggered flow.
Changes:
- Restricts
.github/workflows/release.ymltoworkflow_dispatchonly and removes the prior automatic “check-release” gating logic. - Simplifies version bumping to rely solely on
workflow_dispatchinputs (with an option to publish the current.csprojversion). - Updates the SDK/package version constants in
src/stream-feed-net.csprojandsrc/Client.cs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/stream-feed-net.csproj |
Changes the NuGet package <Version> value (currently set to 6.0.0 in this PR). |
src/Client.cs |
Updates the hardcoded VersionName used for the X-Stream-Client header to match the SDK version. |
.github/workflows/release.yml |
Removes push-based triggering and the check-release job; release now runs only when manually dispatched and uses dispatch inputs for bumping. |
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:24
release.ymlis now manual-only (workflow_dispatch). TheCreate Release PRworkflow currently tells reviewers that merging the PR will automatically create a release, which is no longer true once the push trigger is removed; please update that workflow/PR template messaging (or reintroduce an automatic trigger) to avoid misleading release operators.
on:
workflow_dispatch:
inputs:
version_bump:
description: 'Version bump type'
required: true
default: 'patch'
type: choice
options:
- patch
- minor
- major
prerelease:
description: 'Is this a prerelease?'
required: false
default: false
type: boolean
use_current_version:
description: 'Skip version bump and publish the version already in .csproj (version_bump is ignored)'
required: false
default: false
type: boolean
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Release | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "master" ] | ||
| workflow_dispatch: | ||
| inputs: |
There was a problem hiding this comment.
The workflow creates releases and pushes commits using GITHUB_TOKEN but does not declare explicit permissions. If the repo default token permission is read-only, git push and gh release create will fail; please add least-privilege permissions (e.g., contents: write) at the workflow or job level.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Set version to 7.0.0 for next patch release - Add branch guard to release workflow (master/main only) - Add [skip ci] support to CI workflow Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
No description provided.