Skip to content

[CHA-2595] ci: enforce manually triggered release flow#30

Merged
mogita merged 4 commits intomasterfrom
cha-2595_manual-release-ci
Mar 6, 2026
Merged

[CHA-2595] ci: enforce manually triggered release flow#30
mogita merged 4 commits intomasterfrom
cha-2595_manual-release-ci

Conversation

@mogita
Copy link
Collaborator

@mogita mogita commented Mar 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 6, 2026 17:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions release workflow to only run via manual dispatch, simplifying the release gating/version-bump logic in CI and aligning release execution with an explicit operator-triggered flow.

Changes:

  • Restricts .github/workflows/release.yml to workflow_dispatch only and removes the prior automatic “check-release” gating logic.
  • Simplifies version bumping to rely solely on workflow_dispatch inputs (with an option to publish the current .csproj version).
  • Updates the SDK/package version constants in src/stream-feed-net.csproj and src/Client.cs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
src/stream-feed-net.csproj Changes the NuGet package <Version> value (currently set to 6.0.0 in this PR).
src/Client.cs Updates the hardcoded VersionName used for the X-Stream-Client header to match the SDK version.
.github/workflows/release.yml Removes push-based triggering and the check-release job; release now runs only when manually dispatched and uses dispatch inputs for bumping.
Comments suppressed due to low confidence (1)

.github/workflows/release.yml:24

  • release.yml is now manual-only (workflow_dispatch). The Create Release PR workflow currently tells reviewers that merging the PR will automatically create a release, which is no longer true once the push trigger is removed; please update that workflow/PR template messaging (or reintroduce an automatic trigger) to avoid misleading release operators.
on:
  workflow_dispatch:
    inputs:
      version_bump:
        description: 'Version bump type'
        required: true
        default: 'patch'
        type: choice
        options:
          - patch
          - minor
          - major
      prerelease:
        description: 'Is this a prerelease?'
        required: false
        default: false
        type: boolean
      use_current_version:
        description: 'Skip version bump and publish the version already in .csproj (version_bump is ignored)'
        required: false
        default: false
        type: boolean

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1 to 5
name: Release

on:
push:
branches: [ "master" ]
workflow_dispatch:
inputs:
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow creates releases and pushes commits using GITHUB_TOKEN but does not declare explicit permissions. If the repo default token permission is read-only, git push and gh release create will fail; please add least-privilege permissions (e.g., contents: write) at the workflow or job level.

Copilot uses AI. Check for mistakes.
mogita and others added 3 commits March 6, 2026 18:14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Set version to 7.0.0 for next patch release
- Add branch guard to release workflow (master/main only)
- Add [skip ci] support to CI workflow

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mogita mogita merged commit 7f0c7a4 into master Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants