E0-F1-S1-T1: Create git-repo Makefile Structure#53
Closed
matt-dresden-caylent wants to merge 6 commits intoGerritCodeReview:mainfrom
Closed
E0-F1-S1-T1: Create git-repo Makefile Structure#53matt-dresden-caylent wants to merge 6 commits intoGerritCodeReview:mainfrom
matt-dresden-caylent wants to merge 6 commits intoGerritCodeReview:mainfrom
Conversation
feat: Add CPM support with envsubst command and development tooling
Adds CPM (Caylent Project Manager) support to git-repo with environment
variable substitution in manifests, comprehensive development tooling, and
test infrastructure improvements.
New Features:
- envsubst command: New `repo envsubst` subcommand for environment variable
substitution in XML manifests
- Supports ${ENVVAR} syntax in manifest files
- Recursively processes all XML files in .repo/manifests/**/*.xml
- Creates .bak backup files before modification
- Comprehensive test coverage (237 test cases)
Repository Configuration:
- Updated REPO_URL to https://github.com/caylent-solutions/git-repo
- Updated BUG_URL to GitHub issues
- REPO_REV now lazy-loads latest caylent-* tag from GitHub API
- Added repo script to setup.py for proper installation
Development Environment:
- Devcontainer: Full VSCode devcontainer setup with all dependencies
- Makefile: Common tasks (test, lint, format, coverage, pre-commit)
- Git Hooks: Pre-push validation runs format, lint, and tests
- .tool-versions: Version pinning for pre-commit (4.0.1) and python (3.12.9)
- requirements-dev.txt: Development dependencies (tox, pytest, black, flake8, isort)
Cleanup:
- Removed all man pages (27 files, 3,282 lines deleted)
- Removed manpage generation scripts
- Removed Python 3.8 test runner (Python 3.12 only)
- Removed .coverage file from repository
Bug Fixes:
- Fixed file copy error handling in project.py (OSError → IOError)
- Removed unnecessary chmod operations on copied files
- Added REPO_REV environment variable to tests to prevent network calls
Testing:
- All 287 tests passing
- Added envsubst test suite with edge case coverage
- Simplified tox.ini to Python 3.12 only
- Tests now run without network dependencies
Files Changed:
- Added (10 files): devcontainer config, Makefile, git hooks, envsubst
command/tests, requirements-dev.txt
- Modified (11 files): repo, project.py, pyproject.toml, tox.ini, run_tests,
setup.py, .gitignore, .flake8, .isort.cfg, .tool-versions
- Deleted (30 files): All man pages, manpage generation scripts, .coverage
* fix: repo download * Fix import order in repo file
…instructions - Add Caylent fork notice to main README.md - Create comprehensive CAYLENT-README.md with installation and usage - Add one-liner to auto-fetch and install latest tag - Document --no-repo-verify requirement until GPG signing is added - Include uninstall instructions
- Reduce server_ready.wait timeout from 120s to 5s - Reduce thread join timeout from 5s to 2s - Add check for alive thread after join - Prevents intermittent test hangs during git push hooks
Replaces tox-based Makefile with spec-compliant structure: - SHELL := /bin/bash with -euo pipefail - All required .PHONY targets: help, lint, format, format-check, check, test, test-unit, test-functional, validate, clean - Placeholder targets fail-fast with non-zero exit and error message - validate depends on check + test; check depends on lint + format-check - clean removes __pycache__, .pytest_cache, .ruff_cache, htmlcov, .coverage - Updated SUBMITTING_PATCHES.md and CAYLENT-README.md with make targets - Added unit/functional pytest markers to pyproject.toml - 10 unit tests verifying Makefile structure and behavior
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull requests to manage code contributions to this repository. Instead, please see README.md which provides full instructions on how to get involved. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
make helpprints all targets with descriptionsmake cleanremoves all cache directories