Skip to content

GWC make use of XMLUtils to make better use of GeoTools Hints#1534

Merged
jodygarnett merged 7 commits into
mainfrom
default-entity-resolver-check
May 28, 2026
Merged

GWC make use of XMLUtils to make better use of GeoTools Hints#1534
jodygarnett merged 7 commits into
mainfrom
default-entity-resolver-check

Conversation

@jodygarnett
Copy link
Copy Markdown
Contributor

Makes use of the new XMLUtils utility methods introduced following PR:

This will need to be merged at the same time. I have named the branches the same, perhaps we can adjust the "downstream integration workflow" to look for same branch to check out.

Before merging this PR please re-run integration test upstream on geotools/geotools#5639 (it looks for branches with the same name default-entity-resolver-check.)

This PR supersedes #1533

@jodygarnett jodygarnett force-pushed the default-entity-resolver-check branch from 0bb62ab to 0ab1591 Compare May 28, 2026 04:46
@jodygarnett jodygarnett force-pushed the default-entity-resolver-check branch from 0ab1591 to ce3bebf Compare May 28, 2026 05:15
@jodygarnett jodygarnett marked this pull request as draft May 28, 2026 18:56
@jodygarnett jodygarnett marked this pull request as ready for review May 28, 2026 18:56
@jodygarnett jodygarnett reopened this May 28, 2026
@jodygarnett
Copy link
Copy Markdown
Contributor Author

Closing / reopen to test against new GeoTools SNAPSHOTs

@jodygarnett
Copy link
Copy Markdown
Contributor Author

jodygarnett commented May 28, 2026

@groldan it looks like you wrote the test which is failing:

java.lang.AssertionError: Concurrent migrateForeignKeys threw on 1/4 threads; see suppressed
        at org.geowebcache.diskquota.jdbc.AbstractForeignKeyMigrationTest.migrateIsConcurrentStartupSafe(AbstractForeignKeyMigrationTest.java:136)
...
Suppressed: org.springframework.jdbc.BadSqlGrammarException: StatementCallback; bad SQL grammar [ALTER TABLE tilepage DROP CONSTRAINT tilepage_tileset_id_fkey]
        at org.springframework.jdbc.support.SQLStateSQLExceptionTranslator.doTranslate(SQLStateSQLExceptionTranslator.java:134)
...
        Caused by: org.postgresql.util.PSQLException: ERROR: constraint "tilepage_tileset_id_fkey" of relation "tilepage" does not exist
        at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2904)
...

Do you have any insight into why this may be failing? Presently failing on JDK21.

  • Update 1: I cannot reproduce the failure locally using JDK17
  • Update 2: Or JDK21
  • Oh wait now the error is gone, I guess this test I just not stable...

@jodygarnett jodygarnett changed the title Make use of XMLUtils to make better use of GeoTools Hints GWC make use of XMLUtils to make better use of GeoTools Hints May 28, 2026
@jodygarnett jodygarnett merged commit c88e507 into main May 28, 2026
16 of 34 checks passed
@jodygarnett jodygarnett deleted the default-entity-resolver-check branch May 28, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants