Skip to content

Add dependency for people model in initial migration#14178

Draft
mattiagiupponi wants to merge 2 commits intomasterfrom
ISSUE_14170
Draft

Add dependency for people model in initial migration#14178
mattiagiupponi wants to merge 2 commits intomasterfrom
ISSUE_14170

Conversation

@mattiagiupponi
Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Apr 28, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the initial migration for the indexing app to include a dependency on the people app's profile_extra_data migration. A critical error was identified in the migration dependency format, where the migration name incorrectly included the app label prefix. A suggestion has been provided to correct this to ensure the migration runs successfully.


dependencies = [
("base", "0096_remove_modeltranslation"),
("people", "0039_profile_extra_data")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The format for migration dependencies is a tuple of (<app_label>, <migration_name>). The migration name you've specified, people.0039_profile_extra_data, is incorrect as it includes the app label prefix. This will cause an error when running migrations, likely a django.db.migrations.exceptions.NodeNotFoundError.

The migration name should be 0039_profile_extra_data.

Suggested change
("people", "0039_profile_extra_data")
("people", "0039_profile_extra_data")

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.57%. Comparing base (b0d8c84) to head (59fb654).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14178      +/-   ##
==========================================
+ Coverage   74.55%   74.57%   +0.01%     
==========================================
  Files         958      959       +1     
  Lines       58041    58172     +131     
  Branches     7919     7948      +29     
==========================================
+ Hits        43275    43380     +105     
- Misses      13000    13028      +28     
+ Partials     1766     1764       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mattiagiupponi mattiagiupponi marked this pull request as draft April 28, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with redinex and people migration order

1 participant