Adds better support for plotting text in 3D at different heights - #4777
Open
landryza wants to merge 11 commits into
Open
Adds better support for plotting text in 3D at different heights#4777landryza wants to merge 11 commits into
landryza wants to merge 11 commits into
Conversation
seisman
reviewed
Aug 3, 2026
| data = {"x": x, "y": y} | ||
|
|
||
| if z is not None: | ||
| data["z"] = z |
Member
There was a problem hiding this comment.
Could you please ada a test to ensure it works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds a
zparameter toFigure.textto explicitly expose support for 3D text placement in perspective plots. Previously, users could not provide z coordinates through the PyGMT API even though the underlying GMT module supports 3D text input.This PR:
zparameter totext.py-Zoption viazvaluezFixes Better support for plotting text in 3D at different heights #1393
Reviewer feedback requested
I would especially appreciate guidance on tests for this feature. I ran the existing tests to make sure nothing was broken with this implementation, but I'm struggling to create tests that ensure this was implemented correctly.
Preview:
N/A