Force GMT_DATA_SERVER to static for tests by default#8932
Open
Force GMT_DATA_SERVER to static for tests by default#8932
Conversation
seisman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our test suites use the datasets from the "static" data server, which doesn't change frequently. However, the GMT_DATA_SERVER defaults to "oceania", so that anyone who wants to run the tests (including the CI) must explicitly set
GMT_DATA_SERVERtostatic, otherwise he will see many surprising failures (for example, #8910 (comment)).I think it makes more sense to set the
GMT_DATA_SERVERtostaticby default for tests. This PR does:GMT_DATA_SERVERtostaticwhenDO_TESTSis enabled and the value is still the defaultoceaniaGMT_DATA_SERVER staticoverrides fromci/config-gmt-unix.shandci/config-gmt-windows.shWith changes in this PR, we no longer need to set
GMT_DATA_SERVERtostaticwhen doing tests. Of course, if you like, you can still setGMT_DATA_SERVERto any value (not "oceania") to use a specific data server.