Skip to content

Fix a buffer overflow. #8928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 1 commit into from
Mar 17, 2026
+4 −2
Merged

Fix a buffer overflow. #8928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/gmt_remote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,8 +486,10 @@ int gmt_remote_dataset_id (struct GMTAPI_CTRL *API, const char *ifile) {
/* Must handle the use of srtm_relief vs earth_relief for the 01s and 03s data */
if (strncmp (&ifile[pos], "srtm_relief_0", 13U) == 0) /* Gave strm special name */
sprintf (file, "earth_%s", &ifile[pos+5]); /* Replace srtm with earth */
else /* Just copy as is from pos */
strcpy (file, &ifile[pos]);
else { /* Just copy as is from pos */
strncpy (file, &ifile[pos], PATH_MAX - 1);
file[PATH_MAX - 1] = '\0';
}
key = bsearch (file, API->remote_info, API->n_remote_info, sizeof (struct GMT_DATA_INFO), gmtremote_compare_key);
if (key) { /* Make sure we actually got a real hit since file = "earth" will find a key starting with "earth****" */
char *ckey = strrchr (key->file, '.'); /* Find location of the start of the key file extension (or NULL if no extension) */
Expand Down
Loading