-
Notifications
You must be signed in to change notification settings - Fork 404
8867b fixtest layout #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8867b fixtest layout #8885
Conversation
|
I think I've brought the layout inline with the expected pattern. |
|
When I run The file |
|
Sorry to still have that mixed up. I've made a few more adjustments and the pull should work for you now. |
|
Before I try. Does it work for you? 😄 |
|
Yes, I deleted the baseline and the cache entries locally, and dvc was able to pull the baseline image and then I successfully ran the ctest. |
test/baseline/postscriptlight.dvc
Outdated
| size: 26087 | ||
| hash: md5 | ||
| path: fillTransparency.ps | ||
| path: postscriptlight/fillTransparency.ps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't put the ps file under postscriptlight. It should go to the program that is being tested (sorry, forgot the name, psxy?).
|
Ihad placed it there because I had modified the postscriptlight.c file to fix the bug and because there wasn't a 'plot' test directory. |
|
Saw the issue with the Code Validator, I'm adjusting the test script to be more like the others |
|
Well, that part now works ... but psldemo.ps got removed and now its tests fails |
|
I've replaced the test/baseline/postscriptlight/psldemo.ps file in the dvc repository and verified pulling it |
joa-quim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good now. Thanks and sorry for all this confusion. I hate the DVC but have nothing better to propose,
Corrected layout of fillTransparency baseline.
Reminders