docs(ci): note the check-approval gate on release PRs - #23
Merged
Conversation
v1.0.11 published and tagged fine, then its bump PR sat with no checks reported: GitHub held both runs as `action_required` because `github-actions[bot]` had no merged PR in the repo yet and the fork-PR approval policy was `first_time_contributors`. Auto-merge waits forever on checks that never report. Policy is now `first_time_contributors_new_to_github` and the bot has a merged PR, so it shouldn't come back. Documented anyway with the one command to clear it, since the symptom looks like a hung release rather than a permission prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment in
release.ymlfor the one thing that needed hands during the v1.0.11 release.npm, the tag and the GitHub release all completed on their own. The bump PR then sat with no checks reported, because GitHub held both runs as
action_required:github-actions[bot]had no merged PR in this repo yet and the fork-PR approval policy wasfirst_time_contributors. Auto-merge waits on checks that never arrive, so the PR just sat there.The policy is now
first_time_contributors_new_to_githuband the bot has a merged PR from #22, so this shouldn't recur. Worth a comment regardless: the symptom reads as a hung release, not as something waiting on a click, and the fix is one API call.