fix: SinglePhaseWell Thermal - #4126
Open
tjb-ltk wants to merge 4 commits into
Open
Conversation
…on contribution to well system when solving well only system . These are singlephase only issues
tjb-ltk
requested review from
OmarDuran,
dkachuma,
frankfeifan,
jhuang2601 and
rrsettgast
as code owners
August 19, 2026 17:30
tjb-ltk
added
ci: run CUDA builds
frankfeifan
reviewed
Aug 20, 2026
|
|
||
| void SinglePhaseWell::registerWellDataOnMesh( WellElementSubRegion & subRegion ) | ||
| { | ||
| updateNumDofPerElement(); |
Contributor
There was a problem hiding this comment.
Maybe we don't need to call it again, since it will be called in WellControls::registerDataOnMesh( subRegion ); at the following line.
Contributor
Author
There was a problem hiding this comment.
Thanks... I removed that and unified the setup of a couple of var, hope it doesn't change the baselines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compositional wells were correct. The code was refactored a bit to avoid duplication in matrix stamping and Dof definition