fix: WaveEquation backward propagation and adjoint test#4051
Open
bd713 wants to merge 3 commits into
Open
Conversation
bd713
requested review from
MelReyCG,
OmarDuran,
dkachuma and
wrtobin
as code owners
bd713
added
the
ci: run integrated tests
bd713
added
ci: run CUDA builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed backward propagation to correctly mirror the forward indexing (off-by-one in
beginIndexandseismoIndex).allowed to pass the adjoint test up to machine single precision (threshold tightened from
9e-3to5e-7)reduced test mesh size from
20×25×30to7×6×5elements (source/receiver coordinates adjusted accordingly) to speed up CI. See issue Unit test speed issues #4047The test now runs in under one second on CI
Ubuntu 24.04 - gcc 13:268/270 Test #268: testWavePropagationAdjoint1 ............................. Passed 0.61 sec