feat: support non-scalar valued field specifications #4034
Open
feat: support non-scalar valued field specifications #4034
Conversation
Contributor
|
@rrsettgast does this work for you? |
rrsettgast
requested changes
May 7, 2026
Member
rrsettgast
left a comment
There was a problem hiding this comment.
Really only two potential issues I have:
- It seems like the tensorial specifications are a completely separate thing from the scalar specifications. They should be able to be made into the same thing.
- The introduction of
regionNamesseems like it is duplicating theobjectPathcapability but just cutting out theElementRegions/regionName*? Can you comment on how the usage is improved?
| objectPath="ElementRegions/Region1/block1" | ||
| fieldName="rockPerm_permeability" | ||
| scale="2.0e-22"/> | ||
| scales="{ 2.0e-22, 2.0e-22, 2.0e-22 }"/> |
Member
There was a problem hiding this comment.
you can just leave this as scale?
Comment on lines
+88
to
+92
| registerWrapper( viewKeyStruct::scalesString(), &m_scales ). | ||
| setInputFlag( InputFlags::OPTIONAL ). | ||
| setSizedFromParent( 0 ). | ||
| setDescription( "Apply scaling factors for the values of every component of the boundary condition." ); | ||
|
|
Member
There was a problem hiding this comment.
What is the driver to make a new m_scales instead of generalizing m_scale?
Comment on lines
+71
to
+77
| registerWrapper( viewKeyStruct::functionNamesString(), &m_functionNames ). | ||
| setRTTypeName( rtTypes::CustomTypes::groupNameRefArray ). | ||
| setInputFlag( InputFlags::OPTIONAL ). | ||
| setSizedFromParent( 0 ). | ||
| setDescription( "Names of per-component functions that specifies variation of the boundary condition.\n" | ||
| "Either left empty or sized exactly like 'scales'." ); | ||
|
|
Member
There was a problem hiding this comment.
similar to the m_scales comment below. Can we generalize m_bcApplicaitonFunctionName to serve the role you have here for m_functionNames?
Comment on lines
+433
to
+434
| /// @return The key for regionNames | ||
| constexpr static char const * regionNamesString() { return "regionNames"; } |
Member
There was a problem hiding this comment.
Is this to avoid ElementRegions/regionName type specifications in objectPath?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes field specifications to support non-scalar values, notably scales (and so function names).
The following interface is proposed:
Instead of:
This PR also add a
regionNamesarray to make it easier to specify multiple regions.Considerations
Implementations considerations:
Design choice
I added a separate
scalesattribute (on top of the already existingscale) and afunctionNamesattribute (on top of the already existingfunctionName) to keep backward compatibility with every input files.The user must choose one way to describe its field specification,
either the scalar way:
or the non-scalar way:
and will not be able to use both at the same time.
Other possible implementations
There are different ways this PR could have been implemented, like:
scaleattribute in favor of a non-scalarscalesscale="42"andscale="{ 42 }"as the same type)FieldSpecification