Fix two asserts per linter advice #328
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses linter warnings by replacing two assertTrue(x <= y) assertions with the more specific assertLessEqual(x, y) assertions in the addon comparison test.
Changes:
- Replaced
assertTrue(same <= aa)withassertLessEqual(same, aa)on line 420 - Replaced
assertTrue(aa <= same)withassertLessEqual(aa, same)on line 421
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
419
to
+421
| same = Addon("A", branch="A") | ||
| self.assertTrue(same <= aa) | ||
| self.assertTrue(aa <= same) | ||
| self.assertLessEqual(same, aa) | ||
| self.assertLessEqual(aa, same) |
There was a problem hiding this comment.
These three lines are identical duplicates of lines 415-417. This duplication appears to have been present in the original code and should be removed to avoid redundant test assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.