This repository was archived by the owner on Feb 20, 2024. It is now read-only.
Fallback on suite test globals if none provided#97
Open
ianwsperber wants to merge 1 commit intoFormidableLabs:mainfrom
Open
Fallback on suite test globals if none provided#97ianwsperber wants to merge 1 commit intoFormidableLabs:mainfrom
ianwsperber wants to merge 1 commit intoFormidableLabs:mainfrom
Conversation
ianwsperber
requested review from
carbonrobot
and removed request for
keithcom
carbonrobot
reviewed
Dec 10, 2020
| }); | ||
|
|
||
| for (const fnName of ['it', 'test']) { | ||
| it(`should use the global "${fnName}" if no test function is provided`, async () => { |
Contributor
There was a problem hiding this comment.
Should test be async here? I don't see any usage of await in this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small enhancement to fallback to test suite globals if none is provided. Should help with usability.