feat: add AM mediation check to WebAuthn and export storage config types - #762
feat: add AM mediation check to WebAuthn and export storage config types#762vatsalparikh wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 315063f The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 315063f
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗. ☁️ Nx Cloud last updated this comment at |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (24.39%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
+ Coverage 18.07% 24.39% +6.31%
==========================================
Files 155 164 +9
Lines 24398 25829 +1431
Branches 1203 1707 +504
==========================================
+ Hits 4410 6301 +1891
+ Misses 19988 19528 -460
🚀 New features to boost your workflow:
|
|
Deployed 37c4b24 to https://ForgeRock.github.io/ping-javascript-sdk/pr-762/37c4b2480d609cdcd4e67045442d01ec66d302d8 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/device-client - 0.0 KB (new) 📊 Minor Changes📈 @forgerock/sdk-types - 9.1 KB (+0.0 KB) ➖ No Changes➖ @forgerock/recognize - 4284.4 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
8fe6f90 to
042f664
Compare
042f664 to
315063f
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
We reviewed all 16 failing e2e tasks and determined they are pre-existing infrastructure failures unrelated to this PR's changes. The errors — recursive Nx task loops, localhost port conflicts (5829, 8443), and downstream connection-refused failures — appear identically on the main branch, confirming they were not introduced here. No code fix is needed; a CI rerun should resolve the transient port contention.
No code changes were suggested for this issue.
Trigger a rerun:
🎓 Learn more about Self-Healing CI on nx.dev
4 participants
Merge after 2.2 release
JIRA ticket
https://pingidentity.atlassian.net/browse/SDKS-5367
Summary
WebAuthn.isConditionalMediationSupportednow optionally accepts aJourneyStepand, when provided, also checks that AM requested conditional mediation via the WebAuthn metadata (meta.mediation === 'conditional')BrowserStorageConfig,CustomStorageConfigfrom@forgerock/storageandCustomStorageObjectfrom@forgerock/sdk-typesoffoidc-client's types entry point