test(journey-app): support signalsInitializationOptions for protect test - #758
test(journey-app): support signalsInitializationOptions for protect test#758ancheetah wants to merge 1 commit into
Conversation
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 948cfcf
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed b5bc4b3 to https://ForgeRock.github.io/ping-javascript-sdk/pr-758/b5bc4b33bf64e8d74174e5a3309c9f53be695bc3 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/device-client - 0.0 KB (new) ➖ No Changes➖ @forgerock/sdk-types - 9.1 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
Yeah, I think it is worth testing |
vatsalparikh
left a comment
There was a problem hiding this comment.
Up for discussion: Should we add an additional test for signalsInitializationOptions? And should it use the mock api or a live tenant?
Yeah, we should add the test, both mock and live tenant if possible.
ede4600 to
948cfcf
Compare
|
After some discussion, we decided to opt for using the mock api with these AM Protect tests. Please re-review. |
JIRA Ticket
None
Description
Fixes the Protect component in the
journey-appto supportsignalsInitializationOptions. WhensignalsInitializationOptionsare returned in a PingOneProtectInitializationCallback they are given priority over the standard config. These options may not contain anenvIdbut the journey should still complete successfully without it.The Protect test in our journey e2e test suites runs against the mock api only so we didn't catch this. When running against a live tenant with
signalsInitializationOptionsthis test will fail with out this fix.Up for discussion: Should we add an additional test for
signalsInitializationOptions? And should it use the mock api or a live tenant?