Add DaVinci flow support to PingOne MFA sample app#189
Add DaVinci flow support to PingOne MFA sample app#189EvgeniyMish wants to merge 7 commits intoForgeRock:mfa-proxy-pocfrom
Conversation
…e orchestration-sdk
…app menu is in AppDrawer
…rawer, edited READMEmd
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mfa-proxy-poc #189 +/- ##
================================================
Coverage ? 28.20%
Complexity ? 864
================================================
Files ? 291
Lines ? 9316
Branches ? 1182
================================================
Hits ? 2628
Misses ? 6433
Partials ? 255
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JIRA Ticket
P14C-82519
Description
Summary
This MR extends the PingOne MFA sample app with DaVinci integration. It adds a DaVinci launcher, editable DaVinci environment configurations, and flow rendering that supports PingOne MFA-specific collectors for mobile payload collection and device pairing.
Changes
Added :davinci module dependency to samples:pingonemfapp.
Added DaVinci configuration management:
Default payload and pairing flow configurations.
Editable client ID, discovery endpoint, scopes, redirect URI, display name, timeout, and storage file name.
JSON persistence through SharedPreferences.
Added DaVinci launcher flow from the app drawer.
Added DaVinci flow screen and ViewModel for starting flows, advancing nodes, and handling success/error/failure states.
Added PingOne MFA-specific DaVinci collector handling:
device-payload collector calls PingOneMFA.collectMobilePayload().
device-pairing-code collector calls PingOneMFA.pair(...).
Retry and submit UI handling around collector state.
Reworked app navigation to use a shared drawer with Accounts, Launch DaVinci, Settings, and About.
Removed the old login screen.
Added reusable UI components for alerts, retry, and submit buttons.
Updated strings and README documentation to describe the new DaVinci sample flows.