Skip to content

Add DaVinci flow support to PingOne MFA sample app#189

Open
EvgeniyMish wants to merge 7 commits intoForgeRock:mfa-proxy-pocfrom
EvgeniyMish:mfa-proxy-poc-davinci
Open

Add DaVinci flow support to PingOne MFA sample app#189
EvgeniyMish wants to merge 7 commits intoForgeRock:mfa-proxy-pocfrom
EvgeniyMish:mfa-proxy-poc-davinci

Conversation

@EvgeniyMish
Copy link
Copy Markdown

JIRA Ticket

P14C-82519

Description

Summary

This MR extends the PingOne MFA sample app with DaVinci integration. It adds a DaVinci launcher, editable DaVinci environment configurations, and flow rendering that supports PingOne MFA-specific collectors for mobile payload collection and device pairing.

Changes

Added :davinci module dependency to samples:pingonemfapp.
Added DaVinci configuration management:
Default payload and pairing flow configurations.
Editable client ID, discovery endpoint, scopes, redirect URI, display name, timeout, and storage file name.
JSON persistence through SharedPreferences.
Added DaVinci launcher flow from the app drawer.
Added DaVinci flow screen and ViewModel for starting flows, advancing nodes, and handling success/error/failure states.
Added PingOne MFA-specific DaVinci collector handling:
device-payload collector calls PingOneMFA.collectMobilePayload().
device-pairing-code collector calls PingOneMFA.pair(...).
Retry and submit UI handling around collector state.
Reworked app navigation to use a shared drawer with Accounts, Launch DaVinci, Settings, and About.
Removed the old login screen.
Added reusable UI components for alerts, retry, and submit buttons.
Updated strings and README documentation to describe the new DaVinci sample flows.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b7225c1b-f911-4d25-9650-916507ce336a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (mfa-proxy-poc@4e0db63). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             mfa-proxy-poc     #189   +/-   ##
================================================
  Coverage                 ?   28.20%           
  Complexity               ?      864           
================================================
  Files                    ?      291           
  Lines                    ?     9316           
  Branches                 ?     1182           
================================================
  Hits                     ?     2628           
  Misses                   ?     6433           
  Partials                 ?      255           
Flag Coverage Δ
unit-tests 28.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant