Conversation
WalkthroughThis pull request introduces several modifications, including an update to the Vaadin version in the Changes
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Member
|
I did some testing as the fix includes things that I've already tried without success so I was intrigued.
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pom.xml (1)
263-268: Clarify the Duplicate Resource Bases ConfigurationThe new
<webApp>element (lines 263–268) defines the same resource bases as those already present in<webAppConfig>. Please verify whether both configurations are required for the current Jetty setup with Vaadin 24. If they are both needed (for example, if one is used for a specific deployment mode), consider adding an inline comment to clarify the rationale. Otherwise, removing the duplication could simplify the configuration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (18)
pom.xml(2 hunks)src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChart.java(2 hunks)src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChartItem.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/orgchart/client/OrgChartState.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/orgchart/client/constants/ChartConstants.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/orgchart/client/enums/ChartDirectionEnum.java(1 hunks)src/main/java/com/flowingcode/vaadin/addons/orgchart/extra/TemplateLiteralRewriter.java(1 hunks)src/main/resources/META-INF/frontend/fc-orgchart.js(3 hunks)src/main/resources/META-INF/resources/frontend/fc-orgchart-styles.css(2 hunks)src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java(1 hunks)src/test/java/com/flowingcode/vaadin/addons/orgchart/BottomTopDemo.java(1 hunks)src/test/java/com/flowingcode/vaadin/addons/orgchart/DemoView.java(1 hunks)src/test/java/com/flowingcode/vaadin/addons/orgchart/DragAndDropExportDemo.java(1 hunks)src/test/java/com/flowingcode/vaadin/addons/orgchart/HybridEnhancedChartDemo.java(1 hunks)src/test/java/com/flowingcode/vaadin/addons/orgchart/ImageInTitleDemo.java(1 hunks)src/test/java/com/flowingcode/vaadin/addons/orgchart/OrgchartDemoView.java(1 hunks)src/test/resources/META-INF/resources/frontend/styles/orgchart/demo-styles.css(2 hunks)src/test/resources/META-INF/resources/frontend/styles/orgchart/hybrid-demo-styles.css(3 hunks)
✅ Files skipped from review due to trivial changes (15)
- src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChartItem.java
- src/test/java/com/flowingcode/vaadin/addons/orgchart/ImageInTitleDemo.java
- src/test/resources/META-INF/resources/frontend/styles/orgchart/hybrid-demo-styles.css
- src/test/java/com/flowingcode/vaadin/addons/orgchart/DragAndDropExportDemo.java
- src/test/java/com/flowingcode/vaadin/addons/DemoLayout.java
- src/main/java/com/flowingcode/vaadin/addons/orgchart/client/constants/ChartConstants.java
- src/main/java/com/flowingcode/vaadin/addons/orgchart/client/OrgChartState.java
- src/test/java/com/flowingcode/vaadin/addons/orgchart/BottomTopDemo.java
- src/main/java/com/flowingcode/vaadin/addons/orgchart/client/enums/ChartDirectionEnum.java
- src/test/java/com/flowingcode/vaadin/addons/orgchart/HybridEnhancedChartDemo.java
- src/test/java/com/flowingcode/vaadin/addons/orgchart/DemoView.java
- src/main/java/com/flowingcode/vaadin/addons/orgchart/extra/TemplateLiteralRewriter.java
- src/main/resources/META-INF/resources/frontend/fc-orgchart-styles.css
- src/test/java/com/flowingcode/vaadin/addons/orgchart/OrgchartDemoView.java
- src/test/resources/META-INF/resources/frontend/styles/orgchart/demo-styles.css
🚧 Files skipped from review as they are similar to previous changes (2)
- src/main/java/com/flowingcode/vaadin/addons/orgchart/OrgChart.java
- src/main/resources/META-INF/frontend/fc-orgchart.js
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-vaadin14
🔇 Additional comments (1)
pom.xml (1)
532-539: Update Vaadin Version in the v24 ProfileThe v24 profile now overrides the global Vaadin version by setting
<vaadin.version>24.3.20</vaadin.version>(line 534) along with updating the compiler source/target to 17 and the Jetty version. This aligns with the upgrade objectives. Just ensure that this override does not conflict with other profiles or the default settings declared earlier in the<properties>section.
Member
Author
I updated the jetty plugin configuration. |
paodb
approved these changes
Apr 3, 2025
github-project-automation
bot
moved this from In Progress
to Pending release
in Flowing Code Addons
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had to upgrade Vaadin 24 to 24.3 because 23.2 failed with
Summary by CodeRabbit
Chores
New Features
json-diggerversion 2.0.2) that is now available globally.