Skip to content

fix: remove v0.1 experiment flag toggle from create feature modal#7907

Open
Zaimwa9 wants to merge 3 commits into
mainfrom
fix/remove-experiment-flag-toggle
Open

fix: remove v0.1 experiment flag toggle from create feature modal#7907
Zaimwa9 wants to merge 3 commits into
mainfrom
fix/remove-experiment-flag-toggle

Conversation

@Zaimwa9

@Zaimwa9 Zaimwa9 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Removes the legacy "Experiment flag" toggle from the create/edit feature modal — this was a v0.1 artifact superseded by the experiment freeze mechanism which checks for running experiments via the API.

How did you test this code?

  • Manually

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner June 29, 2026 15:45
@Zaimwa9 Zaimwa9 requested review from talissoncosta and removed request for a team June 29, 2026 15:45
@vercel

vercel Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Jul 14, 2026 6:28pm
flagsmith-frontend-staging Ready Ready Preview, Comment Jul 14, 2026 6:28pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jul 14, 2026 6:28pm

Request Review

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jun 29, 2026
@github-actions github-actions Bot added the fix label Jun 29, 2026
@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7907 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7907 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-7907 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7907 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7907 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-7907 Finished ✅ Results ✅

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  19.5 seconds
commit  a63233b
info  🔄 Run: #17924 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  19.2 seconds
commit  a63233b
info  🔄 Run: #17924 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 11 seconds
commit  a63233b
info  🔄 Run: #17924 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  56.3 seconds
commit  a63233b
info  🔄 Run: #17924 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  46.5 seconds
commit  5f0cc53
info  🔄 Run: #18139 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  17.9 seconds
commit  5f0cc53
info  🔄 Run: #18139 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 6 seconds
commit  5f0cc53
info  🔄 Run: #18139 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  35 seconds
commit  5f0cc53
info  🔄 Run: #18139 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  10.5 seconds
commit  21587d7
info  🔄 Run: #18256 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  45.9 seconds
commit  21587d7
info  🔄 Run: #18256 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  6 passed

Details

stats  6 tests across 5 suites
duration  42.2 seconds
commit  21587d7
info  🔄 Run: #18256 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  4 passed

Details

stats  4 tests across 3 suites
duration  19 seconds
commit  21587d7
info  🔄 Run: #18256 (attempt 1)

@github-actions

github-actions Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

talissoncosta
talissoncosta reviewed Jun 30, 2026
View reviewed changes
Comment thread frontend/web/components/feature-summary/FeatureRow.tsx
@Zaimwa9 Zaimwa9 requested a review from talissoncosta July 9, 2026 15:54
@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 07b77315-9f0d-423f-8cf1-9737dbc45864

📥 Commits

Reviewing files that changed from the base of the PR and between 5f0cc53 and 21587d7.

📒 Files selected for processing (3)
  • frontend/common/services/useExperimentResults.ts
  • frontend/common/types/requests.ts
  • frontend/common/types/responses.ts
💤 Files with no reviewable changes (2)
  • frontend/common/services/useExperimentResults.ts
  • frontend/common/types/responses.ts
📝 Walkthrough

Walkthrough

This change removes the experiment-mode feature creation flow. The create-experiment modal module and its results tab component are deleted, including experiment charting and statistics visualisations. The experimentMode and defaultExperiment props and related branching are removed from feature creation components, consolidating editing around CreateFlagModal. Experiment toggle logic and UI are removed, and experiment result request and response contracts are deleted or restructured.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added fix and removed fix labels Jul 9, 2026
talissoncosta
talissoncosta reviewed Jul 14, 2026
View reviewed changes
Comment thread frontend/web/components/modals/create-experiment/ExperimentResultsTab.tsx
YAxis,
} from 'recharts'
import { colorTextSecondary, colorTextSuccess } from 'common/theme/tokens'
import { useGetExperimentResultsQuery } from 'common/services/useExperimentResults'

@talissoncosta talissoncosta Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExperimentResultsTab was the last consumer of useGetExperimentResultsQuery, so it seems to be dead now. Worth removing it too?

@Zaimwa9 Zaimwa9 Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, addressed here 21587d7

talissoncosta
talissoncosta previously approved these changes Jul 14, 2026
View reviewed changes

@talissoncosta talissoncosta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, but the PR looks good! Thanks for the cleanup @Zaimwa9 !

@github-actions github-actions Bot added fix and removed fix labels Jul 14, 2026
@Zaimwa9 Zaimwa9 requested a review from talissoncosta July 14, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talissoncosta talissoncosta Awaiting requested review from talissoncosta

At least 1 approving review is required to merge this pull request.

Assignees

@talissoncosta talissoncosta

Labels

fix front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zaimwa9 @talissoncosta