Skip to content

ci: integrate Qlty coverage reporting #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davehenton wants to merge 1 commit into from
+15 −7
Closed

ci: integrate Qlty coverage reporting #6980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/api-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: API Pull Request

permissions:
contents: read # For actions/checkout
id-token: write # For Codecov OIDC

on:
pull_request:
Expand Down Expand Up @@ -80,9 +79,10 @@ jobs:
run: make test

- name: Upload Coverage
uses: codecov/codecov-action@v5
env:
PYTHON: ${{ matrix.python-version }}
if: matrix.python-version == '3.13'
uses: qltysh/qlty-action/coverage@v2
with:
env_vars: PYTHON
use_oidc: true
token: ${{ secrets.QLTY_COVERAGE_TOKEN }}
files: coverage.xml
Copy link

@cursor cursor bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage file path wrong due to working directory

High Severity

The files paths in both Qlty coverage upload steps are incorrect. defaults.run.working-directory only applies to run steps, not uses steps — the action resolves files relative to the repo root. make test generates api/coverage.xml but files: coverage.xml looks at the root. Similarly, Jest generates frontend/coverage/lcov.info but files: coverage/lcov.info looks at the root. Both uploads will fail to find their coverage files.

Additional Locations (1)
Fix in Cursor Fix in Web

tag: api
add-prefix: api/
10 changes: 9 additions & 1 deletion .github/workflows/frontend-pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,12 @@ jobs:
run: npm ci

- name: Run unit tests
run: npm run test:unit -- --passWithNoTests
run: npm run test:unit -- --passWithNoTests --coverage

- name: Upload Coverage
uses: qltysh/qlty-action/coverage@v2
with:
token: ${{ secrets.QLTY_COVERAGE_TOKEN }}
files: coverage/lcov.info
tag: frontend
add-prefix: frontend/