Skip to content

feat: Add created_by to MasterAPIKey model#6845

Open
matthewelwell wants to merge 3 commits intomainfrom
feat/add-creator-field-to-master-api-keys
Open

feat: Add created_by to MasterAPIKey model#6845
matthewelwell wants to merge 3 commits intomainfrom
feat/add-creator-field-to-master-api-keys

Conversation

@matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Mar 4, 2026 •
edited
Loading

Changes

Add 'created by' to Organisation API keys for better auditing.

How did you test this code?

Updated existing unit test and tested frontend changes locally.

@vercel
Copy link

vercel bot commented Mar 4, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Mar 4, 2026 9:26pm
flagsmith-frontend-staging Ready Ready Preview, Comment Mar 4, 2026 9:26pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Mar 4, 2026 9:26pm

Request Review

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request and removed feature New feature or request labels Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (877c321) to head (6f2f9ec).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6845   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files        1336     1337    +1     
  Lines       49615    49628   +13     
=======================================
+ Hits        48790    48803   +13     
  Misses        825      825

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewelwell matthewelwell marked this pull request as ready for review March 4, 2026 19:47
@matthewelwell matthewelwell requested a review from a team as a code owner March 4, 2026 19:47
@matthewelwell matthewelwell requested review from khvn26 and removed request for a team March 4, 2026 19:47
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6845 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6845 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6845 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-6845 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6845 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-6845 Finished ✅ Results ✅

@matthewelwell matthewelwell requested a review from a team as a code owner March 4, 2026 21:24
@matthewelwell matthewelwell requested review from kyle-ssg and removed request for a team March 4, 2026 21:24
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request and removed feature New feature or request labels Mar 4, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  24 seconds
commit  6f2f9ec
info  🔄 Run: #15125 (attempt 1)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  10 passed

Details

stats  10 tests across 7 suites
duration  49.3 seconds
commit  6f2f9ec
info  🔄 Run: #15125 (attempt 1)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  16 passed

Details

stats  16 tests across 13 suites
duration  1 minute, 5 seconds
commit  6f2f9ec
info  🔄 Run: #15125 (attempt 1)

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  45.7 seconds
commit  6f2f9ec
info  🔄 Run: #15125 (attempt 1)

Zaimwa9
Zaimwa9 approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and safe to me, haven't tested it yet, will do but approving to not block

Zaimwa9
Zaimwa9 requested changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, old store pattern required to get the users.

NIT: Columns are slightly misaligned

Image

Zaimwa9
Zaimwa9 approved these changes Mar 9, 2026
View reviewed changes
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving following offline discussion unless we have a stable way to reproduce the fallback behavior I experienced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

@khvn26 khvn26 Awaiting requested review from khvn26 khvn26 is a code owner automatically assigned from Flagsmith/flagsmith-back-end

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees

No one assigned

Labels

api Issue related to the REST API feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewelwell @Zaimwa9