feat(grok): add skills-only support for grok build - #1349
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughGrok Build is added as a supported skills-only tool with ChangesGrok Build skills-only support
CLI artifact language contract
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change adds Grok Build through the existing fixed-directory skills integration without adding command execution or new privileges. No actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant InitCommand
participant AI_TOOLS
participant SkillGeneration
participant CommandAdapterRegistry
InitCommand->>AI_TOOLS: resolve grok with skillsDir .grok
InitCommand->>SkillGeneration: generate skills under .grok/skills
InitCommand->>CommandAdapterRegistry: look up Grok Build adapter
CommandAdapterRegistry-->>InitCommand: no adapter registered
InitCommand-->>InitCommand: skip command-file generation and log reason
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (7 skipped: 7 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/how-commands-work.md (1)
83-87: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winClarify Grok’s slash-based skill invocation.
The new row correctly uses
/openspec-propose, but the surrounding guidance says skill-based tools use skills “instead of slash commands” while the page’s generic instructions still direct users to/opsx. Qualify those instructions or explicitly state that Grok uses/openspec-*slash-invoked skills.Suggested wording
-| Grok Build | skill-style, e.g. `/openspec-propose` | +| Grok Build | skill-style slash invocation, e.g. `/openspec-propose` | -A few tools surface OpenSpec as named skills instead of slash commands; for those you invoke the skill by name. +Some tools surface OpenSpec as named skills; use the tool-specific slash syntax shown above.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/how-commands-work.md` around lines 83 - 87, Clarify the guidance in docs/how-commands-work.md to explicitly state that Grok invokes its skills through /openspec-* slash commands, while other named-skill tools may use non-slash invocation. Align the generic instructions with the Grok Build row and existing /opsx guidance without changing the command mappings.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/how-commands-work.md`:
- Around line 83-87: Clarify the guidance in docs/how-commands-work.md to
explicitly state that Grok invokes its skills through /openspec-* slash
commands, while other named-skill tools may use non-slash invocation. Align the
generic instructions with the Grok Build row and existing /opsx guidance without
changing the command mappings.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e0e690d2-4e58-4560-a084-18b5c0d97647
📒 Files selected for processing (15)
docs/cli.mddocs/commands.mddocs/how-commands-work.mddocs/supported-tools.mddocs/troubleshooting.mdopenspec/changes/archive/2026-07-11-add-grok-build-skills-only-support/.openspec.yamlopenspec/changes/archive/2026-07-11-add-grok-build-skills-only-support/design.mdopenspec/changes/archive/2026-07-11-add-grok-build-skills-only-support/proposal.mdopenspec/changes/archive/2026-07-11-add-grok-build-skills-only-support/specs/ai-tool-paths/spec.mdopenspec/changes/archive/2026-07-11-add-grok-build-skills-only-support/specs/cli-init/spec.mdopenspec/changes/archive/2026-07-11-add-grok-build-skills-only-support/tasks.mdopenspec/specs/ai-tool-paths/spec.mdopenspec/specs/cli-init/spec.mdsrc/core/config.tstest/core/init.test.ts
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
clay-good
changed the title
2 participants
Status
LGTM. Ready for final review on commit
38b44b749: the branch is conflict-free, and hosted Linux, macOS, Windows, lint/type, release-tracking, Security, and CodeRabbit checks pass. No additional code changes were warranted by the architecture and safety re-audit.Motivation
Grok Build discovers native project skills in
.grok/skills, but OpenSpec did not register it as a tool. Users otherwise needed a compatibility path or manual skill setup.What it does
grokas a skills-only tool using.grok/skills/openspec-*/SKILL.md./openspec-proposeand other skill invocations, the native path, and the requirement forskillsorbothdelivery.The integration matches the official Grok skill contract.
Proof it works
both,skills, andcommandsdelivery.Notes
Commands-only delivery intentionally follows existing adapterless-tool behavior: it installs no Grok workflows and removes managed Grok skill folders on update, including files inside those folders. Unrelated configuration, commands, and custom skills remain intact. No workflow definitions, defaults, capability model, or global configuration schema change.
The Grok application itself was not launched; verification covers OpenSpec's generated artifacts against the documented integration surface. Archived change artifacts retain their historical context.