Skip to content

docs(cli): document env-var apiKey support for custom models#669

Merged
factory-arman merged 2 commits intomainfrom
arman/FAC-12401-docs-env-keys
Feb 19, 2026
Merged

docs(cli): document env-var apiKey support for custom models#669
factory-arman merged 2 commits intomainfrom
arman/FAC-12401-docs-env-keys

Conversation

@factory-arman
Copy link
Contributor

@factory-arman factory-arman commented Feb 19, 2026

Summary

  • document ${VAR_NAME} support for customModels[].apiKey in settings.json/settings.local.json
  • update BYOK examples to show env var usage instead of hardcoded API keys
  • clarify that env expansion does not apply to legacy ~/.factory/config.json

factory-arman and others added 2 commits February 18, 2026 20:24
Closes FAC-12401

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@factory-arman factory-arman marked this pull request as ready for review February 19, 2026 04:29
@factory-droid
Copy link
Contributor

factory-droid bot commented Feb 19, 2026

Droid finished @factory-arman's task —— View job


  • Fetched PR metadata + diff + file patches
  • Reviewing for any P0/P1 issues and reconciling prior bot comments/threads

Copy link
Contributor

@factory-droid factory-droid bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look correct: they consistently document ${VAR_NAME} env-var expansion for apiKey in settings.json/settings.local.json, and clarify that legacy config.json does not get env expansion. No P0/P1 issues found.

@factory-arman factory-arman merged commit 7d21bfc into main Feb 19, 2026
4 checks passed
@factory-arman factory-arman deleted the arman/FAC-12401-docs-env-keys branch February 19, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments