Mixin regex remap in method selector#166
Merged
Merged
Conversation
modmuss50
reviewed
May 19, 2026
| Comparator | ||
| .<TrMethod, String>comparing(trMethod -> trMethod.getOwner().getName()) | ||
| .thenComparing(TrMember::getName) | ||
| .thenComparing(TrMember::getDesc) |
Member
There was a problem hiding this comment.
Indented 12 times, might be time to start thinking about creating a method.
Contributor
Author
There was a problem hiding this comment.
Extracted it to resolveAndRemapMixinRegex
…handling # Conflicts: # src/main/java/net/fabricmc/tinyremapper/extension/mixin/soft/annotation/injection/CommonInjectionAnnotationVisitor.java # src/test/java/net/fabricmc/tinyremapper/extension/mixin/integration/MixinIntegrationTest.java
modmuss50
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the capability to resolve mixin regex and remap resolved methods in method selectors.
Passes mixin audit for fabric-api
0.149.1+26.2with modern-yarn.The relevant mixin in fabric-api: https://github.com/FabricMC/fabric-api/blob/c3c10324a2b2973e6d1f9896a256f8df7f223c85/fabric-permission-api-v1/src/main/java/net/fabricmc/fabric/mixin/permission/CommandSourceStackMixin.java#L68
Resolving mixin regex in
@At.targetis not included for now and may come in a future PR. Pushing this out to get fabric-api working first.