fix(kimaki): resolve eslint findings in dm-agent-sync plugin#172
Merged
Conversation
Move the getSitePath() call below the wp-availability early return to satisfy @wordpress/no-unused-vars-before-return (was computing sitePath before a possible early return). Annotate the two intentional operational console.warn calls with eslint-disable-next-line no-console so the lint gate passes without dropping the session-console logging. These were pre-existing findings from the Kimaki 0.13 cleanup that blocked 'homeboy release' at the preflight lint gate. Fixes the release preflight lint failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSitePath()below the wp-availability early return to satisfy@wordpress/no-unused-vars-before-return(the blocking error).console.warncalls witheslint-disable-next-line no-consoleso the lint gate passes without dropping session-console logging.Why
These pre-existing findings (from the "Integrate Kimaki 0.13 cleanup" commit, at/before v1.2.1) block
homeboy releaseat the preflight lint gate. Surfaced while cutting v1.2.2.Verification
homeboy lint→passed: true, 0 findings, exit 0.node tests/effective-prompt/run.mjs→ 2 scenarios pass.