Skip to content

Fix NoopProvider unsafe null assertion #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roryabraham wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Draft

Fix NoopProvider unsafe null assertion #841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/storage/providers/NoopProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
import type {OnyxValue} from '../../types';
import type {OnyxKey, OnyxValue} from '../../types';
import {StorageErrorClass} from '../errors';
import type StorageProvider from './types';

function emptyOnyxValue<TKey extends OnyxKey>(key: TKey): OnyxValue<TKey>;
function emptyOnyxValue(): null {
return null;
}

const provider: StorageProvider<unknown> = {
store: undefined,

Expand All @@ -26,7 +31,7 @@ const provider: StorageProvider<unknown> = {
* Get the value of a given key or return `null` if it's not available in memory
*/
getItem(_key) {
return Promise.resolve(null as OnyxValue<typeof _key>);
return Promise.resolve(emptyOnyxValue(_key));
},

/**
Expand Down
Loading