Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Collaborator
Author
|
recheck |
tomekzaw
reviewed
May 25, 2025
jmusial
commented
May 27, 2025
Collaborator
Author
jmusial
left a comment
There was a problem hiding this comment.
While testing noticed that the issue is also present for left arrow when navigating backwards and /or with multiple emojis. Added code and test cases to cover that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes navigation bug on Firefox, where navigation using arrows over emojis requires 2 key presses.
Screen.Recording.2025-05-21.at.09.55.11.mov
Details
In Firefox, the arrow key navigation treats surrogate pairs (like emojis) as two separate code units, while Chromium browsers treat them as a single character. This discrepancy causes the “double-arrow press” behaviour.
Related Issues
GH_LINK
Manual Tests
Videos
Before
LM_emojis_before.mov
After
LM_emojis_after.mov
Linked PRs