Draft
Conversation
Contributor
Author
|
Some feedback: Currently
Tamagui, Gluestack, etc have all upstreamed these functions into their own libs, as seen here. I haven't implemented these changes yet, I'll wait for feedback first. CC @tomekzaw |
|
I can vouch for these changes as being beneficial generally for web compat. Ideally it'd be a mostly headless setup and all native files are in .native, with web being the "default". This makes for no-config setups. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
(Still a draft)
Removes any dependency on React Native, React Native Web, for Web users. Nothing changes for native. This should drastically fix any installation steps / config issues for Web users. Without these changes, web users will flood your issues constantly lol.
.web.tsxfiles to be.native.tsxPlatform.selectin favor of.native.tsxStyleSheet.createStyleSheet.flatten(slow and not useful for this case)inheritforcaretColorinstead ofStyleSheet.flatten(props.style).color(pure CSS implementation, reproduction)webStyleUtilsstyle = {}in the web file which broke memoization entirely for no benefit.Breaking change
There is one breaking change: Consumers using
StyleSheet.createon web will no longer work. They should be converted to plain style objects. This can be easily addressed with an error message. This breaking change could be easily reverted, but I recommend keeping it. Zeego made this change, and it was well worth it.Related Issues
GH_LINK
Closes #579
Manual Tests
Linked PRs