Add customUnitRateOutOfDateRange violation for date-bound mileage rates

[Krishna2323]

Explanation of Change

Fixed Issues

$ #89837
PROPOSAL:

Tests

Setup

1. Use a workspace with distance rates enabled.
2. In Workspace → Distance rates, create at least two rates, e.g.:
   • Rate A: $0.67/mi, valid Jan 1 – Dec 31, 2025
   • Rate B: $0.70/mi, valid Jan 1 – Dec 31, 2026
   • (Optional) Rate C: start date only, Rate D: end date only — for message variants
3. Test on web (and one mobile platform if you can).

---

1. Primary — out-of-range rate on confirmation

1. + → Submit expense → pick the workspace chat.
2. Create a distance expense (manual distance or map route).
3. Set date to Jun 15, 2026 (outside Rate A).
4. On confirmation, open Rate and manually select Rate A (2025 rate).
5. Verify:
   • Red brick road on Rate field
   • Message like: Rate is only valid from Jan 1, 2025 to Dec 31, 2025
   • No duplicate error at the bottom of the form
   • Submit / Create is not blocked

---

2. Fix by changing date

1. From the failing state above, tap Date → pick Jun 15, 2025.
2. Verify:
   • Rate error clears (if Rate A is still selected)
   • Submit is enabled

---

3. Fix by changing rate

1. Set date back to Jun 15, 2026.
2. Open Rate → select Rate B (2026 rate).
3. Verify: error clears, submit enabled.

---

4. Date change auto-selects eligible rate (no error)

1. New distance expense, date Jun 15, 2025, default rate = Rate A.
2. Change date to Jun 15, 2026 (date step should auto-switch to Rate B).
3. Verify:
   • No out-of-date-range error on confirmation
   • If rate changed, auto-update tooltip may show (from [Due for payment 2026-06-22] [DB MileageRate] App: Update confirmation and rate selection UX for date-aware mileage rates #89835)
   • Tooltip should not show when the out-of-date error is present (test 1 vs this case)

---

5. Manually override auto-selected rate

1. After step 4 auto-selects Rate B, open Rate and manually pick Rate A again.
2. Verify: out-of-date error returns, submit blocked.

---

6. Message variants

Repeat test 1 with rates that have only one bound:

Rate setup	Expense date	Expected message
Start only: Jan 1, 2025	Dec 2024	Rate is only valid from Jan 1, 2025
End only: Dec 31, 2025	Jan 2026	Rate is only valid until Dec 31, 2025
Both dates	Outside range	Rate is only valid from … to …

---

7. invalidRate vs out-of-date (don’t mix them up)

1. Distance expense on workspace with a valid rate for the date → no error.
2. Pick a disabled rate or one not on the policy → should show Rate is not valid (iou.error.invalidRate), not the date-range message.
3. Verify: only one rate-related error at a time.

---

8. P2P / personal distance (no date-range violation)

1. + → distance expense to a personal contact (not workspace).
2. Use default P2P rate with any date.
3. Verify: no customUnitRateOutOfDateRange error (P2P uses fake rate ID).

---

9. Track expense flow

1. Track distance on a workspace policy.
2. Repeat test 1 (out-of-range rate + date).
3. Verify: same inline error.

---

10. Post-save violation (edit existing expense)

1. Create & save a distance expense with matching date + rate.
2. Open the expense → Edit → change date outside the rate’s range (keep same rate).
3. Save if allowed, or confirm on the edit confirmation screen.
4. Verify:
   • Violation on the Rate field in expense details (MoneyRequestView)
   • Same formatted message as on confirmation
   • Warning type (non-blocking on saved expense, if your policy allows save-with-warnings)

• Verify that no errors appear in the JS console

Offline tests

• Same as tests

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[Krishna2323]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cbb254f893

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Krishna2323]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73d4a526b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[Krishna2323]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa7a0a699b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Add the new violation strings to every locale

When the user’s locale is anything other than English and this new out-of-date rate violation is rendered, translate('violations.customUnitRateOutOfDateRange', ...) has no matching key in the generated locale files (checked es/fr/de/it/nl/pl/pt-BR/ja/zh-hans). Localize.translate does not fall back to English for missing keys, so this path logs/throws in development and shows the key or missing-translation text in production instead of the rate message. Please add the three new customUnitRateOutOfDateRange* entries to the non-English locale files as well.

Useful? React with 👍 / 👎.