refactor: remove getReportTransactions calls from UI component#87131
Open
linhvovan29546 wants to merge 8 commits intoExpensify:mainfrom
Open
refactor: remove getReportTransactions calls from UI component#87131linhvovan29546 wants to merge 8 commits intoExpensify:mainfrom
linhvovan29546 wants to merge 8 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…MostRecentIOUReportAction
linhvovan29546
commented
Apr 5, 2026
Contributor
Author
Because I removed the dead code |
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
No product review needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
getReportTransactionsusage from all React component and hook callers, replacing them with theuseReportTransactionsCollectionhook (or useOnyx where hooks can't be called in a loop). This is part of the effort to remove the module-level Onyx.connect() for ONYXKEYS.COLLECTION.TRANSACTION in ReportUtils.tsisIOUReportPendingCurrencyConversion, since it’s dead code and no longer used.Note:
getReportTransactionsis still used at the lib/action level (ReportUtils.ts, IOU/index.ts, Report/index.ts, Search.ts, TransactionUtils, etc.). These are non-React pure functions that can't use hooks. Migrating those usages will be handled in a later phase.Fixed Issues
$ #66418
PROPOSAL: N/A
Tests
Test 1:
Test 2:
Test 3:
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-05.at.16.30.05.mov
Android: mWeb Chrome
Screen.Recording.2026-04-05.at.16.19.20.mov
iOS: Native
Screen.Recording.2026-04-05.at.16.24.59.mov
iOS: mWeb Safari
Screen.Recording.2026-04-05.at.16.18.05.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-05.at.16.05.05.mov
Screen.Recording.2026-04-05.at.16.16.32.mov