Fix crash when importing employee CSV files#87085
Closed
marufsharifi wants to merge 1 commit intoExpensify:mainfrom
Closed
Fix crash when importing employee CSV files#87085marufsharifi wants to merge 1 commit intoExpensify:mainfrom
marufsharifi wants to merge 1 commit intoExpensify:mainfrom
Conversation
7 tasks
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@marufsharifi Could you please close this PR? Really sorry for the back-and-forth—I wasn’t aware of the modal migration. Thanks for your understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This change makes the import-result dialog behave like a normal page-owned modal instead of opening it through the app’s global modal stack.
The final “import succeeded/failed” message is now shown directly from the screen state that already decides when it should appear. This removes the extra modal lifecycle that was causing the members import flow to become unstable in the confirmation-path edge case, while keeping the user-facing behavior the same: same message, same confirm button, same close/navigation outcome.
Fixed Issues
$ #86704
PROPOSAL: #86704 (comment)
Tests
Offline tests
Same as Tests.
QA Steps
Same as Test.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-03.at.6.26.41.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-04-03.at.6.19.44.PM.mov
iOS: Native
Screen.Recording.2026-04-03.at.6.08.18.PM.mp4
iOS: mWeb Safari
Screen.Recording.2026-04-03.at.6.12.07.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-03.at.5.39.38.PM.mov