Fix Report- Something when wrong when resize to fullscreen in bar or line view of expense report by borys3kk · Pull Request #87084 · Expensify/App

borys3kk · 2026-04-03T12:49:24Z

Explanation of Change

Fixed chart crashes caused by excessive re-renders. Moved activeDataIndex and isOverClickableTarget from React state to Reanimated SharedValues so hover/cursor changes no longer trigger React re-renders. Extracted ChartTooltipLayer to read shared values directly. Refactored useChartLabelLayout to return label widths only; truncation is now handled during render in ChartXAxisLabels. Added useChartLabelMeasurements, useChartParagraphs, and useYAxisLabelWidth hooks.

Fixed Issues

$ #87066 (I was unable to reproduce the crash when resizing however I've noticed while testing locally that both charts are re-rendered on every mouse hover, chart point / bar enter etc, and this also seems to fix the something went wrong crash)

PROPOSAL:

Tests

Crash fix:

Go to reports tab
Select type:expense
Select group-by:merchant
Resize window in multiple times
Maximize the window
Ensure that no crash occurs

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-04-03.at.16.06.23.mov

codecov · 2026-04-03T12:57:09Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...omponents/Charts/hooks/useChartInteractionState.ts	`100.00% <100.00%> (+28.57%)`	⬆️
...rc/components/Charts/hooks/useChartInteractions.ts	`68.96% <100.00%> (+3.39%)`	⬆️
src/components/Charts/hooks/useChartLabelLayout.ts	`100.00% <100.00%> (ø)`
...mponents/Charts/hooks/useChartLabelMeasurements.ts	`100.00% <100.00%> (ø)`
.../components/Charts/components/ChartYAxisLabels.tsx	`0.00% <0.00%> (ø)`
src/components/Charts/hooks/useChartParagraphs.ts	`0.00% <0.00%> (ø)`
src/components/Charts/hooks/useLabelHitTesting.ts	`0.00% <0.00%> (ø)`
src/components/Charts/hooks/useYAxisLabelWidth.ts	`0.00% <0.00%> (ø)`
...components/Charts/components/ChartTooltipLayer.tsx	`0.00% <0.00%> (ø)`
src/components/Charts/BarChart/BarChartContent.tsx	`5.00% <0.00%> (-0.36%)`	⬇️
... and 3 more
... and 631 files with indirect coverage changes

mhawryluk

Awesome! 🚀

melvin-bot · 2026-04-03T14:55:58Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c976df66b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify

Fix is good for product

borys3kk · 2026-04-07T07:45:39Z

hi @DylanDylann, how's the review coming along?

DylanDylann · 2026-04-07T09:14:20Z

On my list today

DylanDylann · 2026-04-07T09:24:19Z

@codex review

chatgpt-codex-connector · 2026-04-07T09:47:50Z

Codex Review: Didn't find any major issues. Hooray!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-04-07T10:01:43Z

@borys3kk I think this bug only reproduces on Windows; unfortunately, I don’t have it. Could you ask someone to verify it there? Otherwise, we should ask the QA team to test this PR using an ad-hoc build.

borys3kk · 2026-04-07T10:13:32Z

@borys3kk I think this bug only reproduces on Windows; unfortunately, I don’t have it. Could you ask someone to verify it there? Otherwise, we should ask the QA team to test this PR using an ad-hoc build.

I was also able to reproduce this bug on macOS so I think you're good to go

DylanDylann · 2026-04-07T10:41:49Z

@borys3kk The code change looks fine to me

Could you update and add unit tests?

src/components/Charts/utils.ts	61.90% <0.00%> (-5.34%)	⬇️

borys3kk · 2026-04-07T10:46:00Z

@borys3kk The code change looks fine to me

Could you update and add unit tests?

src/components/Charts/utils.ts 61.90% <0.00%> (-5.34%) ⬇️

sure, on it

borys3kk · 2026-04-07T11:30:26Z

@DylanDylann pushed newest changes with added tests 🚀

DylanDylann · 2026-04-07T13:49:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

DylanDylann · 2026-04-07T17:21:35Z

can't complete the review today, I will prioritise this PR in tomorrow

DylanDylann · 2026-04-08T05:38:08Z

@borys3kk I still get a crash

Screen.Recording.2026-04-08.at.12.37.12.mov

borys3kk · 2026-04-08T08:49:25Z

@borys3kk I still get a crash

Screen.Recording.2026-04-08.at.12.37.12.mov

looking into it

…f skia paragraph builder, cleanup

borys3kk · 2026-04-09T13:39:20Z

taking the pr back to draft for internal review, when that concludes I will ping you

mateuuszzzzz · 2026-04-09T13:53:48Z

+ * width actually changes — not when the parent passes a new array reference with the same strings.
+ */
+function useChartParagraphs(labels: string[], fontMgr: SkTypefaceFontProvider | null, fontSize: number, labelColor: string, layoutWidth: number): ParagraphWithWidth[] {
+    // Join into a single string so useMemo compares label content, not the array reference.


Do we actually need this labelsKey workaround?
If we memoize labels in the parent (so the array reference is stable when values don’t change), this hook could just depend on labels directly.

Maybe there's no need to do anything extra if the parent is compiled with React Compiler.

yeah, I've tried it but the labels array is not stable itself and creates a new reference on every resize even though the values do not change

…r line and bar chart content

borys3kk · 2026-04-13T08:56:25Z

@DylanDylann pr is ready for your re-review 🚀

borys3kk · 2026-04-16T11:51:25Z

hello, @DylanDylann how's the review coming along? 🚀

fix line and bar charts many re-renders leading to a crash

5533b52

melvin-bot bot assigned borys3kk Apr 3, 2026

borys3kk added 2 commits April 3, 2026 15:04

fix truncated y axis labels in edge cases

e564bf9

fix deprecated styles

58935ab

mhawryluk reviewed Apr 3, 2026

View reviewed changes

Comment thread src/components/Charts/components/ChartTooltipLayer.tsx Outdated

remove unnecessary display name

4c976df

mhawryluk approved these changes Apr 3, 2026

View reviewed changes

borys3kk marked this pull request as ready for review April 3, 2026 14:55

borys3kk requested review from a team as code owners April 3, 2026 14:55

melvin-bot bot requested review from DylanDylann and removed request for a team April 3, 2026 14:55

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team April 3, 2026 14:55

borys3kk mentioned this pull request Apr 3, 2026

[$250] Report- Something when wrong when resize to fullscreen in bar or line view of expense report #87066

Open

7 tasks

chatgpt-codex-connector bot reviewed Apr 3, 2026

View reviewed changes

Comment thread src/components/Charts/components/ChartTooltipLayer.tsx

anchor ChartTooltipLayer

ab2c6dc

joekaufmanexpensify previously approved these changes Apr 3, 2026

View reviewed changes

improve test coverage

5ef0796

borys3kk dismissed joekaufmanexpensify’s stale review via 5ef0796 April 7, 2026 10:55

improve re-render count, make props more stable, reuse one instance o…

f2bde33

…f skia paragraph builder, cleanup

borys3kk marked this pull request as draft April 9, 2026 13:39

mateuuszzzzz reviewed Apr 9, 2026

View reviewed changes

borys3kk added 4 commits April 10, 2026 15:39

refactor useChartLabelLayout to not handle labels truncation, refacto…

210458b

…r line and bar chart content

fix yet another truncated label problem

ae47f14

fix utils lint error

b57f560

fix tests

c0bacf2

mateuuszzzzz approved these changes Apr 13, 2026

View reviewed changes

borys3kk marked this pull request as ready for review April 13, 2026 08:39

mhawryluk reviewed Apr 13, 2026

View reviewed changes

Comment thread src/components/Charts/hooks/useChartParagraphs.ts Outdated

fix comments in functions and hooks

e09ce53

Conversation

borys3kk commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

mhawryluk left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

borys3kk commented Apr 7, 2026

Uh oh!

DylanDylann commented Apr 7, 2026

Uh oh!

DylanDylann commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector bot commented Apr 7, 2026

Uh oh!

DylanDylann commented Apr 7, 2026

Uh oh!

borys3kk commented Apr 7, 2026

Uh oh!

DylanDylann commented Apr 7, 2026

Uh oh!

borys3kk commented Apr 7, 2026

Uh oh!

borys3kk commented Apr 7, 2026

Uh oh!

DylanDylann commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Apr 7, 2026

Uh oh!

DylanDylann commented Apr 8, 2026

Uh oh!

borys3kk commented Apr 8, 2026

Uh oh!

borys3kk commented Apr 9, 2026

Uh oh!

mateuuszzzzz Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

borys3kk Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

borys3kk commented Apr 13, 2026

Uh oh!

Uh oh!

borys3kk commented Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

borys3kk commented Apr 3, 2026 •

edited

Loading

codecov bot commented Apr 3, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Apr 7, 2026 •

edited

Loading