Make EditReportFieldDropdown use new SelectionListWithSections#80321
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
I think this change may cause a regression if someone uses this keyForList to search
There was a problem hiding this comment.
same as in the other PR, it should be fixed now 😊
| import type {OptionData} from './ReportUtils'; | ||
| import tokenizedSearch from './tokenizedSearch'; | ||
|
|
||
| type ReportFieldOption = Option & {keyForList: string}; |
There was a problem hiding this comment.
Why do we need to change it? keyForList is already in Option
There was a problem hiding this comment.
As I understand type Option = Partial<OptionData>, which has keyForList so to avoid problems with string | undefined incompatibility I added this type
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-01-28.at.00.30.48.movAndroid: mWeb ChromeScreen.Recording.2026-01-28.at.00.27.46.moviOS: HybridAppScreen.Recording.2026-01-28.at.00.31.36.moviOS: mWeb SafariScreen.Recording.2026-01-28.at.00.28.07.movMacOS: Chrome / SafariScreen.Recording.2026-01-28.at.00.24.43.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.3.11-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|
Explanation of Change
Fixed Issues
$ #65658
PROPOSAL:
Tests
ReportsReport fieldsOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-01-23.at.12.33.24.mov