Add DualEntry support for vendor matching - #100678
Draft
lakchote wants to merge 5 commits into
Draft
Conversation
Add Rillet to vendor matching cascade, wire empty state, and update WorkspaceMoreFeaturesPage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
DualEntry now supports the expense vendor picker, Vendors page, merchant rules, and vendor-name lookup. These features use the same eligible vendors as export. DualEntry follows Rillet in the source order and requires the
vendorMatchingbeta and a configured connection.The default vendor picker for company cards uses the same eligibility check. The helpers distinguish a list that has not loaded from an empty list. Empty lists use the existing DualEntry translations.
This PR builds on Rillet PR #100542, which is open in a contributor fork. It targets
main, so the diff includes Rillet commitf1718295909dand four DualEntry commits. Review the DualEntry changes againstf1718295909d. Rebase ontomainafter the Rillet PR merges.Coordinated PRs: Auth, Web-Expensify, Integration-Server, App.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/679020
PROPOSAL:
Tests
All 420 tests in
PolicyUtilsTest.tspassed.lint-changed,typecheck,react-compiler-compliance-check -- check-changed,spell-changed, andgit diff --checkpassed. Live browser and device QA have not been run.These manual steps have not been run.
Prerequisite: Use a workspace with the
vendorMatchingbeta enabled, DualEntry connected and configured, and at least one active vendor available to the selected company.More Features page
Manual vendor selection and search
Automatic vendor matching
Inactive-vendor error
Offline tests
Not run.
QA Steps
Same as tests. For
Credit Card Misc, run the two export checks in the Integration-Server PR.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari