Fix Save button unreachable behind keyboard on EditPromptPage in landscape by NicolasBonet · Pull Request #100643 · Expensify/App

NicolasBonet · 2026-09-08T20:45:44Z

Explanation of Change

#97782 replaced EditPromptPage's landscape scroll fallback with a hardcoded-height keyboard-avoidance strategy, but only wired the new mechanism up on AddAgentPage. On EditPromptPage:

shouldUseScrollView was hardcoded to false (previously landscape-aware)
the scrollToMultilineInput helper added by the same PR was never wired to this page's onFocus
CollapsibleHeaderOnKeyboard only budgets space for the input itself, not the disclaimer text and Save button below it — the shrunk input alone already exceeds that budget

With no ScrollView and no scroll-into-view on focus, the disclaimer text and Save button land behind the keyboard in landscape mode with nothing to scroll them into view (partially hidden on iOS, fully hidden on Android).

This change mirrors the pattern already used and working on AddAgentPage in the same PR: shouldUseScrollView={isInLandscapeMode} and an onFocus handler that calls scrollToMultilineInput.

Fixed Issues

$ #100640
PROPOSAL:

Tests

Go to Account > Agents.
Create an agent, open it.
Tap "Write custom instructions".
Switch device to landscape mode.
Tap the input field to focus it and bring up the keyboard.
Scroll down.
Verify the Save button is reachable and not blocked by the keyboard.

Verify that no errors appear in the JS console

Offline tests

Same as Tests — this screen loads from cached Onyx data and does not require a network request to reproduce or verify the fix.

QA Steps

Go to Account > Agents.
Create an agent, open it.
Tap "Write custom instructions".
Switch device to landscape mode.
Tap the input field to focus it and bring up the keyboard.
Scroll down.
Verify the Save button is reachable and not blocked by the keyboard.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

ScreenRecording_09-08-2026.19-48-11_1.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

…scape #97782 hardcoded shouldUseScrollView to false on EditPromptPage and dropped the onFocus scroll fallback, but the shrunk input already exceeds the space CollapsibleHeaderOnKeyboard reserves for it, so the disclaimer text and Save button land behind the keyboard with nothing to scroll them into view. Mirrors the working AddAgentPage pattern: scroll view is landscape-aware again and the prompt input scrolls into view on focus. Fixes #100640

github-actions · 2026-09-08T20:48:55Z

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

… the footer The shrink-height View has no overflow style, so a prompt longer than the reserved budget painted past its own bounds and visually overlapped the disclaimer and Save button below it instead of scrolling within its own box.

The overflow-clip attempt in the previous commit didn't address the actual gap: EditPromptPage rendered the shrink-height input and the disclaimer as bare FormProvider children, unlike AddAgentPage which groups the equivalent fields inside one flex column. Matching that structure exactly (verified working with long prompts on AddAgentPage) fixes the disclaimer rendering over the input text.

github-actions · 2026-09-08T21:20:20Z

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-08T21:31:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100643.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-0f79840-719d7a0-8bd70de7e0a12479ff9ca5100c82162c2d371e16/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-0f79840-719d7a0-0cfbdce444eb05d3acfc91c9add54d21cb514ac6/index.html

Web 🕸️
https://100643.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

melvin-bot · 2026-09-09T00:50:43Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-09-09T00:50:48Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-09T01:02:42.378329Z	`0f79840`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-09-09T00:53:24Z

    const [agentPrompt] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_AGENT_PROMPT}${accountID}`);
+    const formRef = useRef<FormRef>(null);
+    const promptTopOffsetRef = useRef(0);
+    const handleInputFocus = () => scrollToMultilineInput(formRef, isInLandscapeMode, promptTopOffsetRef.current);


❌ CONSISTENCY-12 (docs)

The declared function handleInputFocus is named for the event it is wired to (the input's onFocus) rather than the action it performs (scrolling the prompt input into view). Per STYLE.md, a callback's definition should be named for its behavior; the on*/handle* naming belongs on the JSX prop, not the function definition. A behavior-based name keeps the handler searchable by intent and reusable across triggers.

Rename the declaration to describe what it does, e.g.:

const scrollPromptIntoView = () => scrollToMultilineInput(formRef, isInLandscapeMode, promptTopOffsetRef.current); // ... <InputWrapper onFocus={scrollPromptIntoView} />

Reviewed at: 0f79840 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

truph01 · 2026-09-09T03:54:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-09.at.14.48.44.mov

Screen.Recording.2026-09-09.at.14.49.40.mov

iOS: HybridApp

Screen.Recording.2026-09-09.at.14.51.09.mov

Screen.Recording.2026-09-09.at.14.57.05.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-09.at.14.57.41.mov

GCyganek · 2026-09-09T07:20:22Z

-                    />
+                <View style={[styles.flex1, styles.flexColumn, styles.gap5]}>
+                    <View
+                        style={shouldShrinkPromptInput ? StyleUtils.getHeight(PROMPT_MAX_HEIGHT_ON_KEYBOARD_OPEN_LANDSCAPE_MODE) : [styles.flex1]}


Should be:

Suggested change

style={shouldShrinkPromptInput ? StyleUtils.getHeight(PROMPT_MAX_HEIGHT_ON_KEYBOARD_OPEN_LANDSCAPE_MODE) : [styles.flex1]}

style={shouldShrinkPromptInput ? StyleUtils.getHeight(PROMPT_MAX_HEIGHT_ON_KEYBOARD_OPEN_LANDSCAPE_MODE) : [isInLandscapeMode ? styles.h42 : styles.flex1]}

here or else it's broken with open keyboard when the prompt is longer:

Screen.Recording.2026-09-09.at.09.19.39.mov

melvin-bot Bot assigned NicolasBonet Sep 8, 2026

This comment has been minimized.

Sign in to view

NicolasBonet added 2 commits September 8, 2026 16:09

NicolasBonet marked this pull request as ready for review September 9, 2026 00:50

NicolasBonet requested review from a team as code owners September 9, 2026 00:50

melvin-bot Bot requested review from heyjennahay and truph01 and removed request for a team September 9, 2026 00:50

melvin-bot Bot removed the request for review from a team September 9, 2026 00:50

github-actions Bot reviewed Sep 9, 2026

View reviewed changes

GCyganek reviewed Sep 9, 2026

View reviewed changes

NicolasBonet closed this Sep 9, 2026

NicolasBonet deleted the fix-100640-edit-prompt-landscape-scroll branch September 9, 2026 14:46

Navigation Menu

Uh oh!

Fix Save button unreachable behind keyboard on EditPromptPage in landscape - #100643

Fix Save button unreachable behind keyboard on EditPromptPage in landscape#100643
NicolasBonet wants to merge 3 commits into
mainfrom
fix-100640-edit-prompt-landscape-scroll

NicolasBonet commented Sep 8, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

melvin-bot Bot commented Sep 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

github-actions Bot Sep 9, 2026

Uh oh!

truph01 commented Sep 9, 2026 •

edited

Loading

Uh oh!

GCyganek Sep 9, 2026

Uh oh!

GCyganek Sep 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	style={shouldShrinkPromptInput ? StyleUtils.getHeight(PROMPT_MAX_HEIGHT_ON_KEYBOARD_OPEN_LANDSCAPE_MODE) : [styles.flex1]}
	style={shouldShrinkPromptInput ? StyleUtils.getHeight(PROMPT_MAX_HEIGHT_ON_KEYBOARD_OPEN_LANDSCAPE_MODE) : [isInLandscapeMode ? styles.h42 : styles.flex1]}

Uh oh!

Conversation

NicolasBonet commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

melvin-bot Bot commented Sep 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

github-actions Bot Sep 9, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-12 (docs)

Uh oh!

truph01 commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

GCyganek Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

GCyganek Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NicolasBonet commented Sep 8, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 9, 2026 •

edited

Loading

truph01 commented Sep 9, 2026 •

edited

Loading