[No QA] Docs updates for E/A#83667 Approve dropdown for reports with held expenses - #100636
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#83667 Approve dropdown for reports with held expenses#100636MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: mkzie2 <mkzie2@users.noreply.github.com>
54 tasks
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://15fbd8ff.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Docs-only follow-up to #83667, which changed how an approver picks between a partial and a full approval when a report contains held expenses.
Before that PR, clicking Approve opened a confirmation modal. It now opens a dropdown menu anchored to the Approve button, with each option labelled with the amount it will approve. The copy in the menu also changed (
iou.confirmApprovalAmountwas replaced byiou.confirmApprovalWithHeldAmount, andiou.confirmApprovalAllHoldAmountis no longer pluralised).docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.mdstill described a confirmation modal, so this updates the "How to approve a report that contains held expenses" section to match. It also notes that the same dropdown appears on the report preview in a chat, and adds a non-rendered screenshot suggestion for the open menu.I verified the live labels on web against the PR branch — the menu header reads "Report contains held expenses. Approve only compliant expenses, or approve the entire report?" and the options read Approve only $40.00 and Approve $65.00 on a report with one held expense:
The all-held state (only Approve [full amount] offered) is taken from the code, not from a live run — I could not reach that state as the approver on the test account.
Fixed Issues
$ #70383
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@mkzie2, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.