Docs updates for E/A#97308 opening a single expense from a report preview - #100634
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#97308 opening a single expense from a report preview#100634MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: wildan-m <wildan-m@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site follow-up for #97308, which changed what happens when you click or tap an expense card in a multi-expense Report Preview carousel: the expense you pressed now opens instead of the parent report.
The only help site article that covers report previews is
docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md. It described what a report preview shows ("Up to 10 expense previews", "Carousel navigation", "+X more link if there are over 10 expenses") but never described what pressing a card does, so it did not need a correction — it needed the missing behavior added.This PR adds it:
Verified against the live UI on web before writing, so the labels match exactly:
$25.00 for Coffee Shop), not the parent report.aria-labeland no hover tooltip, so the article describes them as "the previous and next arrows in the expense header" rather than inventing a label. The previous arrow is disabled on the first expense and the next arrow on the last.MAX_PREVIEWS_NUMBER = 10), so those lines were left alone.Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md: both new headings are task-based##headings starting with an action verb, no###or deeper, button names bolded in the UI's exact capitalization, and the new FAQ entry is phrased as a user question. The article's pre-existing structure (its multiple#headings and noun-only section titles) was left untouched to keep this diff scoped to the behavior change.Fixed Issues
$ #91042
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// This PR only changes markdown under
docs/articles, so there is no app behavior to test — confirming the rendered article reads correctly is the check that matters.Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review", or add "[No QA]" to the title.
// Documentation-only change to a help site article — no app code is touched.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@wildan-m, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.