Docs updates for E/A#98500 full beneficial owner SSN and CAD bank statement - #100632
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#98500 full beneficial owner SSN and CAD bank statement#100632MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
E/A#98500 changed the beneficial owner SSN field from the last four digits to the full nine digits, added a required bank statement upload for CAD accounts and for the Enable Global Reimbursements flow, and replaced Canada's proof of beneficial owner requirement with Schedule 50 from the T2 return. Co-authored-by: Maxence Coulibaly <madmax330@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site updates for the behavior changed by #98500 (
[Payment due @getusha] Add bank statement and ssn requirements). That PR made three user-visible changes that the existing articles either contradicted or did not describe:isValidSSNLastFourtoisValidSSNFullNine, and the input label changed fromLast 4 of SSNtoFull 9 digits of SSN. This affects both the USD business bank account flow and the non-USD global reimbursement flow, and it applies whenever a beneficial owner's country of citizenship is the United States. The signer's own personal details still ask for the last four digits, so that copy was deliberately left alone.isBankStatementNeededexpanded from AUD only to AUD and CAD, andgetStartPageForContinueSetupsends you back to Agreements if you try to resume at the Docusign step without one. The same upload field was also added to the Enable Global Reimbursements flow for USD bank accounts, where it did not exist before.Files changed:
docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md— documents the beneficial owner fields and states that the full SSN is required, and calls out that this differs from the last-four-digit ask in your own personal details.docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Canada.md— adds SSN to the beneficial owner field list, replaces the attestation/org chart requirement with Schedule 50, and adds a new section for the Agreements screen and its bank statement upload.docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-States.md— moves the bank statement upload to where it actually appears (the Agreements screen) and notes that the ACH authorization form is gated behind it.docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-Kingdom.md— correctsSSN only if based in the US, which is now wrong on both the amount asked for and the condition that triggers it.UI labels used in the copy (Full 9 digits of SSN, Bank statement, Choose file, Accept and add bank account, Proof of beneficial owner, Agreements) were taken from the merged strings in
src/languages/en.tsand the components that render them. A browser walk of the CAD setup flow was attempted to confirm them on screen, but it was blocked by the email security-code screen on Connect manually, so the labels are verified against the merged source rather than a live screenshot. Please confirm them against the real flow.Two things intentionally left out of scope:
# Step N:headings in the United States article do not meet the current heading rules indocs/HELP_AUTHORING_GUIDELINES.md(one#per article, task-based headings). Rewriting them would touch sections this PR has no reason to change, so they were left as-is.cspellcould not be run in this environment, so spelling was not machine-verified.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/649256
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@madmax330, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.