Docs updates for E/A#98189 GPS distance duplicates become manual distance - #100630
Draft
MelvinBot wants to merge 1 commit into
Draft
Docs updates for E/A#98189 GPS distance duplicates become manual distance#100630MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: X Developer <x-dev90@users.noreply.github.com>
40 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site updates for the behavior change shipped in #98189.
That PR changed how a GPS distance expense is duplicated. When the source expense is not on a report (Unreported) or the member has no workspace, the duplicate is now created as a manual distance expense: it keeps the saved total distance, but the route map and its start and end waypoints are dropped, because the raw GPS trace is not stored on the saved transaction. GPS distance expenses that are already on a workspace report still duplicate as GPS distance expenses with the route intact.
Neither help article described this, so a member who duplicates a GPS trip would expect the route map to come along. Changes:
docs/articles/new-expensify/reports-and-expenses/How-to-Duplicate-an-Expense.md— new## What happens when you duplicate a GPS distance expensesection, a matching FAQ entry, and updatedkeywords/internalScope.docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.md— new FAQ entry## What happens when I duplicate a GPS Distance expense?and updatedkeywords.UI labels used in the copy (Spend, Expenses, More, Duplicate expense, Track distance, Map, Manual, GPS, Odometer) were verified against the live web UI. Written against
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md.Fixed Issues
$ #91814
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
N/A — documentation only.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@x-dev90, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.