feat: post all livestream URLs upfront instead of per-session#376
Open
AmaanShikalgar wants to merge 1 commit into
Open
feat: post all livestream URLs upfront instead of per-session#376AmaanShikalgar wants to merge 1 commit into
AmaanShikalgar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #375
Posts all three days' livestream URLs upfront in each room's channel topic
(on bot startup), instead of only updating the topic with the current
day's URL right before that day's first session starts. This matches the
format requested in the issue:
Stream Wednesday: [URL]
Stream Thursday: [URL]
Stream Friday: [URL]
The old per-session topic overwrite in
notify_sessionshas been removed,since it would otherwise regress the topic back to a single URL.
Testing: ran pytest, ruff format, and ruff check locally on Windows.
71/72 tests pass. The one failure (test_pretix_connector.py::test_cache)
is pre-existing and unrelated — I confirmed it fails identically with my
changes stashed out, so it looks like a Windows-specific encoding issue
in the Pretix cache loading, unconnected to this PR.