test_closing: [flake] Increase feerate test limit#8664
Closed
ddustin wants to merge 1 commit intoElementsProject:masterfrom
Closed
test_closing: [flake] Increase feerate test limit#8664ddustin wants to merge 1 commit intoElementsProject:masterfrom
ddustin wants to merge 1 commit intoElementsProject:masterfrom
Conversation
ddustin
changed the title
Collaborator
Author
|
@rustyrussell I did a big audit of fee estimation for splice script and noticed a byte was double counted in Perhaps this is part of the issue here? |
ddustin
force-pushed
the
ddustin/ci_fix
branch
from
400fd5c to
5b1401d
Compare
Contributor
|
I would love a PR with that fix, but no, this is a separate flake... |
When locally running test_closing.py `test_peer_anchor_push` in a loop, it failed on the 43rd time with the error: actual_feerate = 12005.233318796338, expected_feerate = 12000 Increasing the expected feerate prevents this particular flake from occuring on CI. Changelog-None
ddustin
force-pushed
the
ddustin/ci_fix
branch
from
5b1401d to
9ae345a
Compare
Collaborator
|
confirmed with dusty: we can ditch this one for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When locally running test_closing.py
test_peer_anchor_pushin a loop, it failed on the 43rd time with the error:actual_feerate = 12005.233318796338, expected_feerate = 12000
Increasing the expected feerate prevents this particular flake.
Hopefully this isn't papering over an important calculation 🤔