fix(openapi): pass custom schema annotations - #7340
Draft
astahmer wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 7816fb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Schema.toJsonSchemaDocumentalready supportsincludeAnnotationKey, which is the opt-in mechanism for carrying custom JSON Schema annotation keys such as vendor extensions.OpenApi.fromApidid not pass that option to the same converter, so those annotations were silently dropped from generated OpenAPI schemas.This is separate from #7192 and #7203, which concern annotations being lost while schemas are lowered across encoding links. This change fixes the missing OpenAPI pass-through.
Change
FromApiOptionsparameter toOpenApi.fromApi.includeAnnotationKeyto the existing JSON Schema compiler.The reproduction and test use only generic names:
Before this change, the generated component was
{ type: "string" }. With the change, it is{ type: "string", "x-test-brand": "Value" }.Verification
pnpm vitest run packages/effect/test/schema/toJsonSchemaDocument.test.ts packages/effect/test/unstable/httpapi/OpenApi.test.ts --project effectpnpm checkpnpm lintThe bug was found and fixed in this patch by Codex, OpenAI's coding agent, while investigating a generated OpenAPI schema integration. The reproduction deliberately contains no application-specific identifiers.