Open
Conversation
mrrobot47
requested changes
Jan 10, 2019
| 'image' => 'easyengine/cron:' . $img_versions['easyengine/cron'], | ||
| 'restart' => 'always', | ||
| 'volumes' => [ | ||
| '/opt/easyengine/services/cron:/etc/ofelia:ro', |
Member
There was a problem hiding this comment.
Use function: EE_DOCKER::get_mounting_volume_array() as in all of above to generate volumes. As the volume generation differs in Linux and macOS.
For the volume /var/run/docker.sock - You can use skip_volume:
service-command/src/helper/service-utils.php
Lines 155 to 160 in 0013571
Once, this change is done, for Linux systems, the cron directory inside the EE_SERVICE_DIR will be a docker volume. So, you'll have to write migrations to take backup of the previous cron directory and then once volume directory get's symlinked, need to restore that data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: EasyEngine/easyengine#1365
Depends on:
https://github.com/EasyEngine/easyengine/pull/1368/files
EasyEngine/cron-command#44