Fix default folder configuration for Symfony 3#80
Open
rubenrubiob wants to merge 1 commit intoEasyCorp:masterfrom
rubenrubiob:bugfix/symfony3-deploy
Open
Fix default folder configuration for Symfony 3#80rubenrubiob wants to merge 1 commit intoEasyCorp:masterfrom rubenrubiob:bugfix/symfony3-deploy
rubenrubiob wants to merge 1 commit intoEasyCorp:masterfrom
rubenrubiob:bugfix/symfony3-deploy
Conversation
|
See #67 for an even better approach which is configurable from userland. |
Contributor
Author
|
Yes, I saw that pull request, but that would not work for Symfony 3.4 either, as the checking for versions are wrong, you can see it with the minor version checking. But that way seems more elegant, indeed, so, if the pull request is merged, I will be happy to do a pull request changing the version checking. It is pretty simple, actually. |
fd6130
approved these changes
Nov 12, 2021
fd6130
left a comment
There was a problem hiding this comment.
This patch indeed fix the issue. Going to merge this to my fork instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
The deployer fails when trying to deploy a Symfony 3.4 application, as the default configuration sets the folder structure as it is a Symfony 4 application. Symfony's documentation explains the architecture for 3.4 applications: https://symfony.com/doc/3.4/quick_tour/the_architecture.html
That is specially true for applications that have been upgraded from earlier versions.
I have removed the check, but maybe the checks should be more accurate? I can try to do it, if I know how versions differ between them.
Thank you!
Regards!