Draft
Conversation
…e. Reviewed CF names beginning with A, still B-Z to go
…ns, fix description typos
…t to always resolve these problems manually
…ed with a bad merge confict resolution
- Greatly simplify logic for reading schema file and handling exceptions in that process - Remove unnecessary logic comments
…mments and strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a draft until #143 is merged, as it contains the same commits
Description
In the process of trying to add a new tool to check for redundant CF name elements (see #143), I found that our existing tools suffer from a number of issues:
This PR resolves those problems. Also, I took the opportunity to clean up the existing tools:
And finally, I added the check for duplicate cfname elements that was the start of this whole process.
Issues
Resolves #118, #144