Skip to content

Fix problems with tools#145

Draft
mkavulich wants to merge 23 commits intoESCOMP:mainfrom
mkavulich:feature/fix_tools
Draft

Fix problems with tools#145
mkavulich wants to merge 23 commits intoESCOMP:mainfrom
mkavulich:feature/fix_tools

Conversation

@mkavulich
Copy link
Copy Markdown
Collaborator

NOTE: This is a draft until #143 is merged, as it contains the same commits

Description

In the process of trying to add a new tool to check for redundant CF name elements (see #143), I found that our existing tools suffer from a number of issues:

This PR resolves those problems. Also, I took the opportunity to clean up the existing tools:

  • Make all python scripts pass pylint with a 10/10 score
  • Standardized the format of comments and multi-line strings
  • Standardized how command-line arguments are named and referenced
  • Removed many unnecessary comments

And finally, I added the check for duplicate cfname elements that was the start of this whole process.

Issues

Resolves #118, #144

mkavulich added 23 commits April 9, 2026 12:12
…e. Reviewed CF names beginning with A, still B-Z to go
 - Greatly simplify logic for reading schema file and handling exceptions in that process
 - Remove unnecessary logic comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update python scripts to use f-strings

1 participant