Repository navigation
Added Argo Workflow Alerts - #1700
Merged
Merged
Conversation
davehadley
requested changes
Oct 6, 2026
hazdl
force-pushed
the
hz/add-argo-workflow-alerts
branch
from
October 6, 2026 10:12
d6d2680 to
0d1ac04
Compare
fix(workflows observability): apdate argo workflow success rate alert thresholds fix: remove unintended file from pr
hazdl
force-pushed
the
hz/add-argo-workflow-alerts
branch
from
October 6, 2026 10:16
0d1ac04 to
52a8aef
Compare
davehadley
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Alerts and Implement High Priority / High Level Alerts AP-1339
Summary
Add initial Prometheus alerting for Argo Workflows and update the monitoring Helm chart version.
Changes
Added ArgoWorkflowControllerFailing alert for the Argo Workflow Controller entering CrashLoopBackOff.
Added ArgoWorkflowsUnhealthy alert to detect newly failed or errored workflows using argo_workflows_count_total.
Added ArgoWorkflowsPending alert when more than 5 workflows remain pending for 15 minutes.
Added ArgoWorkflowSuccessRateLow alert when workflow success rate falls below 80%, with a minimum completed-workflow threshold.
Investigated Argo workflow metrics and changed the unhealthy alert from the historical argo_workflows_gauge metric to the workflow completion counter to avoid duplicate/historical failure counts.
Removed dynamic Prometheus $value templating from the alert description because the rules are rendered through Helm.
Bumped the monitoring Helm chart version from 0.1.34 to 0.1.37 to satisfy the chart version validation.
Validation
helm lint passes locally.
Helm template rendering successfully produces all four alert rules.
Verified the rendered Prometheus alerting configuration.
Follow-up
The dashboard contains additional signals that could be converted into alerts once production baselines and thresholds are agreed:
These should be tracked as follow-up tickets rather than adding arbitrary thresholds to this change.